From 329f65c790c4f63e85c73145b50ac04ab6f5ea89 Mon Sep 17 00:00:00 2001 From: Makoto Kato Date: Mon, 16 Aug 2021 01:40:00 +0000 Subject: [PATCH] Bug 1725593 - Get rid of SendCheckAndSuggest sync IPC. r=masayuki,ipc-reviewers,mccr8 Depends on D122579 Differential Revision: https://phabricator.services.mozilla.com/D122580 --- .../hunspell/glue/PRemoteSpellcheckEngine.ipdl | 2 -- .../hunspell/glue/RemoteSpellCheckEngineParent.cpp | 11 ----------- .../hunspell/glue/RemoteSpellCheckEngineParent.h | 4 ---- ipc/ipdl/sync-messages.ini | 2 -- 4 files changed, 19 deletions(-) diff --git a/extensions/spellcheck/hunspell/glue/PRemoteSpellcheckEngine.ipdl b/extensions/spellcheck/hunspell/glue/PRemoteSpellcheckEngine.ipdl index 23e09fb42cfa..f2612c6c8539 100644 --- a/extensions/spellcheck/hunspell/glue/PRemoteSpellcheckEngine.ipdl +++ b/extensions/spellcheck/hunspell/glue/PRemoteSpellcheckEngine.ipdl @@ -14,8 +14,6 @@ parent: async CheckAsync(nsString[] aWord) returns (bool[] aIsMisspelled); - sync CheckAndSuggest(nsString aWord) returns (bool aIsMisspelled, nsString[] aSuggestions); - sync SetDictionary(nsCString aDictionary) returns (bool success); async Suggest(nsString aWord, uint32_t aCount) returns (nsString[] aSuggestions); diff --git a/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.cpp b/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.cpp index d5e20c412152..160034db441a 100644 --- a/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.cpp +++ b/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.cpp @@ -53,17 +53,6 @@ mozilla::ipc::IPCResult RemoteSpellcheckEngineParent::RecvCheckAsync( return IPC_OK(); } -mozilla::ipc::IPCResult RemoteSpellcheckEngineParent::RecvCheckAndSuggest( - const nsString& aWord, bool* aIsMisspelled, - nsTArray* aSuggestions) { - nsresult rv = mSpellChecker->CheckWord(aWord, aIsMisspelled, aSuggestions); - if (NS_FAILED(rv)) { - aSuggestions->Clear(); - *aIsMisspelled = false; - } - return IPC_OK(); -} - mozilla::ipc::IPCResult RemoteSpellcheckEngineParent::RecvSuggest( const nsString& aWord, uint32_t aCount, SuggestResolver&& aResolve) { nsTArray suggestions; diff --git a/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.h b/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.h index 70ac63ff74eb..1a8d2a61350f 100644 --- a/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.h +++ b/extensions/spellcheck/hunspell/glue/RemoteSpellCheckEngineParent.h @@ -29,10 +29,6 @@ class RemoteSpellcheckEngineParent : public PRemoteSpellcheckEngineParent { virtual mozilla::ipc::IPCResult RecvCheckAsync(nsTArray&& aWord, CheckAsyncResolver&& aResolve); - virtual mozilla::ipc::IPCResult RecvCheckAndSuggest( - const nsString& aWord, bool* aIsMisspelled, - nsTArray* aSuggestions); - virtual mozilla::ipc::IPCResult RecvSuggest(const nsString& aWord, uint32_t aCount, SuggestResolver&& aResolve); diff --git a/ipc/ipdl/sync-messages.ini b/ipc/ipdl/sync-messages.ini index 7bd7c983d993..5aed6480c3a7 100644 --- a/ipc/ipdl/sync-messages.ini +++ b/ipc/ipdl/sync-messages.ini @@ -864,8 +864,6 @@ description = See corresponding comment in PBackgroundLSSnapshot.ipdl description = See corresponding comment in PBackgroundLSSnapshot.ipdl [PBackgroundSessionStorageCache::Load] description = See corresponding comment in PBackgroundSessionStorageCache.ipdl -[PRemoteSpellcheckEngine::CheckAndSuggest] -description = legacy sync IPC - please add detailed description [PRemoteSpellcheckEngine::SetDictionary] description = legacy sync IPC - please add detailed description [PGPU::AddLayerTreeIdMapping]