230970

nsExternalAppHandler needs no virtual functions
also, w/o bug: nsExternalHelperAppService doesn't require threadsafe addref/release
r=bzbarsky sr=darin

uriloader/exthandler/nsExternalHelperAppService.cpp

@@ -386,7 +386,7 @@ static nsDefaultMimeTypeEntry nonDecodableExtensions [] = {
   { APPLICATION_COMPRESS, "Z" }
 };
 
-NS_IMPL_THREADSAFE_ISUPPORTS6(
+NS_IMPL_ISUPPORTS6(
   nsExternalHelperAppService,
   nsIExternalHelperAppService,
   nsPIExternalAppLauncher,

uriloader/exthandler/nsExternalHelperAppService.h

@@ -288,13 +288,13 @@ public:
   NS_DECL_NSIOBSERVER
 
   nsExternalAppHandler();
-  virtual ~nsExternalAppHandler();
+  ~nsExternalAppHandler();
 
-  virtual nsresult Init(nsIMIMEInfo * aMIMEInfo, const char * aFileExtension,
-                        nsISupports * aWindowContext,
-                        const nsAString& aFilename,
-                        PRBool aIsAttachment,
-                        nsExternalHelperAppService *aHelperAppService);
+  nsresult Init(nsIMIMEInfo * aMIMEInfo, const char * aFileExtension,
+                nsISupports * aWindowContext,
+                const nsAString& aFilename,
+                PRBool aIsAttachment,
+                nsExternalHelperAppService *aHelperAppService);
 
 protected:
   nsCOMPtr<nsIFile> mTempFile;
@@ -394,10 +394,10 @@ protected:
   
   /**
    * Helper routine to ensure mSuggestedFileName is "correct";
-   * the base class implementation ensures that mSuggestedFileName has
-   * mTempFileExtension as extension;
+   * this ensures that mTempFileExtension only contains an extension when it
+   * is different from mSuggestedFileName's extension.
    */
-  virtual void EnsureSuggestedFileName();
+  void EnsureSuggestedFileName();
 
   typedef enum { kReadError, kWriteError, kLaunchError } ErrorType;
   /**

uriloader/exthandler/nsExternalProtocolHandler.h

@@ -39,7 +39,7 @@ public:
 	NS_DECL_NSIEXTERNALPROTOCOLHANDLER
 
 	nsExternalProtocolHandler();
-	virtual ~nsExternalProtocolHandler();
+	~nsExternalProtocolHandler();
 
 protected:
   // helper function