From 33507e612699ea73d9e646a3b90225290bf5e9c5 Mon Sep 17 00:00:00 2001
From: Brad Werth <bwerth@mozilla.com>
Date: Wed, 2 May 2018 16:24:20 -0700
Subject: [PATCH] Bug 1456590 Part 1: Omit line names from implicitly named
 areas, to avoid confusion. r=mats

MozReview-Commit-ID: 3vK2MUeEuqw

--HG--
extra : rebase_source : 52b948982757381deed80879917135c887103b2b
---
 dom/grid/GridLines.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/dom/grid/GridLines.cpp b/dom/grid/GridLines.cpp
index ea0a0355b44d..841439e22a3e 100644
--- a/dom/grid/GridLines.cpp
+++ b/dom/grid/GridLines.cpp
@@ -145,6 +145,14 @@ GridLines::SetLineInfo(const ComputedGridTrackInfo* aTrackInfo,
 
       // Add in names from grid areas where this line is used as a boundary.
       for (auto area : aAreas) {
+        // We specifically ignore line names from implicitly named areas,
+        // because it can be confusing for designers who might naturally use
+        // a named line of "-start" or "-end" and create an implicit named
+        // area without meaning to.
+        if (area->Type() == GridDeclaration::Implicit) {
+          continue;
+        }
+
         bool haveNameToAdd = false;
         nsAutoString nameToAdd;
         area->GetName(nameToAdd);