From 342c2113fe9d18a2afb93567bb04182bedf919f6 Mon Sep 17 00:00:00 2001 From: Brad Werth Date: Thu, 9 Jan 2020 18:43:56 +0000 Subject: [PATCH] Bug 1607733: Remove the expiring devtools.wrong_shortcut telemetry. r=Harald Differential Revision: https://phabricator.services.mozilla.com/D59381 --HG-- extra : moz-landing-system : lando --- devtools/client/framework/toolbox.js | 14 -------------- toolkit/components/telemetry/Events.yaml | 14 -------------- 2 files changed, 28 deletions(-) diff --git a/devtools/client/framework/toolbox.js b/devtools/client/framework/toolbox.js index 15eeaba2d50e..db9a6b446fd9 100644 --- a/devtools/client/framework/toolbox.js +++ b/devtools/client/framework/toolbox.js @@ -1047,20 +1047,6 @@ Toolbox.prototype = { if (!this._hostOptions || this._hostOptions.zoom === true) { ZoomKeys.register(this.win, this.shortcuts); } - - // Monitor shortcuts that are not supported by DevTools, but might be used - // by users because they are widely implemented in other developer tools - // (example: the command palette triggered via ctrl+P) - const wrongShortcuts = ["CmdOrCtrl+P", "CmdOrCtrl+Shift+P"]; - for (const shortcut of wrongShortcuts) { - this.shortcuts.on(shortcut, event => { - this.telemetry.recordEvent("wrong_shortcut", "tools", null, { - shortcut, - tool_id: this.currentToolId, - session_id: this.sessionId, - }); - }); - } }, _removeShortcuts: function() { diff --git a/toolkit/components/telemetry/Events.yaml b/toolkit/components/telemetry/Events.yaml index 30b82bfa8e55..934966083f50 100644 --- a/toolkit/components/telemetry/Events.yaml +++ b/toolkit/components/telemetry/Events.yaml @@ -1517,20 +1517,6 @@ devtools.main: prompt_enabled: True if the user enables the prompt, false otherwise. runtime_id: Random id generated to track events related to a single runtime session_id: The start time of the session in milliseconds since epoch (Unix Timestamp) e.g. 1396381378123. - wrong_shortcut: - objects: ["tools"] - bug_numbers: [1567497] - notification_emails: ["dev-developer-tools@lists.mozilla.org", "hkirschner@mozilla.com"] - products: - - "firefox" - record_in_processes: ["main"] - description: User tried to use a shortcut we don't support yet in devtools. - release_channel_collection: opt-out - expiry_version: "75" - extra_keys: - shortcut: The shortcut pressed by the user - tool_id: The id of the panel the user was using - session_id: The start time of the session in milliseconds since epoch (Unix Timestamp) e.g. 1396381378123. security.ui.protections: show: