Bug 1656292 - Enable remaining ESLint rules on editor/libeditor/tests/*.xhtml files. r=masayuki

Differential Revision: https://phabricator.services.mozilla.com/D85450

.eslintrc.js

@@ -444,18 +444,6 @@ module.exports = {
         "no-useless-call": "off",
       },
     },
-    {
-      files: [
-        "editor/composer/test/test_bug434998.xhtml",
-        "editor/libeditor/tests/test_bug607584.xhtml",
-        "editor/libeditor/tests/test_bug616590.xhtml",
-        "editor/libeditor/tests/test_bug780908.xhtml",
-      ],
-      rules: {
-        "object-shorthand": "off",
-        "no-undef": "off",
-      },
-    },
     {
       files: [
         "widget/tests/native_menus_window.xhtml",

editor/composer/test/test_bug434998.xhtml

@@ -36,7 +36,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=434998
   }
 
   EditorContentListener.prototype = {
-    init : function(aEditor)
+    init(aEditor)
     {
       this.mEditor = aEditor;
     },
@@ -44,7 +44,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=434998
     QueryInterface: ChromeUtils.generateQI(["nsIWebProgressListener",
                                             "nsISupportsWeakReference"]),
 
-    onStateChange : function(aWebProgress, aRequest, aStateFlags, aStatus)
+    onStateChange(aWebProgress, aRequest, aStateFlags, aStatus)
     {
       if (aStateFlags & Ci.nsIWebProgressListener.STATE_STOP)
       {
@@ -65,25 +65,25 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=434998
     },
 
 
-    onProgressChange : function(aWebProgress, aRequest,
+    onProgressChange(aWebProgress, aRequest,
                                 aCurSelfProgress, aMaxSelfProgress,
                                 aCurTotalProgress, aMaxTotalProgress)
     {
-    },
+  },
 
-    onLocationChange : function(aWebProgress, aRequest, aLocation, aFlags)
+  onLocationChange(aWebProgress, aRequest, aLocation, aFlags)
     {
     },
 
-    onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage)
+    onStatusChange(aWebProgress, aRequest, aStatus, aMessage)
     {
     },
 
-    onSecurityChange : function(aWebProgress, aRequest, aState)
+    onSecurityChange(aWebProgress, aRequest, aState)
     {
     },
 
-    onContentBlockingEvent : function(aWebProgress, aRequest, aEvent)
+    onContentBlockingEvent(aWebProgress, aRequest, aEvent)
     {
     },
 

editor/libeditor/tests/test_bug607584.xhtml

@@ -36,7 +36,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=607584
   }
 
   EditorContentListener.prototype = {
-    init : function(aEditor)
+    init(aEditor)
       {
         this.mEditor = aEditor;
       },
@@ -44,7 +44,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=607584
     QueryInterface: ChromeUtils.generateQI(["nsIWebProgressListener",
                                             "nsISupportsWeakReference"]),
 
-    onStateChange : function(aWebProgress, aRequest, aStateFlags, aStatus)
+    onStateChange(aWebProgress, aRequest, aStateFlags, aStatus)
     {
         if (aStateFlags & Ci.nsIWebProgressListener.STATE_STOP)
         {
@@ -71,25 +71,25 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=607584
     },
 
 
-    onProgressChange : function(aWebProgress, aRequest,
+    onProgressChange(aWebProgress, aRequest,
                                 aCurSelfProgress, aMaxSelfProgress,
                                 aCurTotalProgress, aMaxTotalProgress)
       {
       },
 
-    onLocationChange : function(aWebProgress, aRequest, aLocation, aFlags)
+    onLocationChange(aWebProgress, aRequest, aLocation, aFlags)
       {
       },
 
-    onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage)
+    onStatusChange(aWebProgress, aRequest, aStatus, aMessage)
       {
       },
 
-    onSecurityChange : function(aWebProgress, aRequest, aState)
+    onSecurityChange(aWebProgress, aRequest, aState)
       {
       },
 
-    onContentBlockingEvent : function(aWebProgress, aRequest, aEvent)
+    onContentBlockingEvent(aWebProgress, aRequest, aEvent)
       {
       },
 

editor/libeditor/tests/test_bug616590.xhtml

@@ -35,7 +35,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=616590
   }
 
   EditorContentListener.prototype = {
-    init : function(aEditor)
+    init(aEditor)
     {
       this.mEditor = aEditor;
     },
@@ -43,7 +43,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=616590
     QueryInterface: ChromeUtils.generateQI(["nsIWebProgressListener",
                                             "nsISupportsWeakReference"]),
 
-    onStateChange : function(aWebProgress, aRequest, aStateFlags, aStatus)
+    onStateChange(aWebProgress, aRequest, aStateFlags, aStatus)
     {
       if (aStateFlags & Ci.nsIWebProgressListener.STATE_STOP)
       {
@@ -60,25 +60,25 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=616590
     },
 
 
-    onProgressChange : function(aWebProgress, aRequest,
+    onProgressChange(aWebProgress, aRequest,
                                 aCurSelfProgress, aMaxSelfProgress,
                                 aCurTotalProgress, aMaxTotalProgress)
     {
     },
 
-    onLocationChange : function(aWebProgress, aRequest, aLocation, aFlags)
+    onLocationChange(aWebProgress, aRequest, aLocation, aFlags)
     {
     },
 
-    onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage)
+    onStatusChange(aWebProgress, aRequest, aStatus, aMessage)
     {
     },
 
-    onSecurityChange : function(aWebProgress, aRequest, aState)
+    onSecurityChange(aWebProgress, aRequest, aState)
     {
     },
 
-    onContentBlockingEvent : function(aWebProgress, aRequest, aEvent)
+    onContentBlockingEvent(aWebProgress, aRequest, aEvent)
     {
     },
 

editor/libeditor/tests/test_bug780908.xhtml

@@ -38,7 +38,7 @@ adapted from test_bug607584.xhtml by Kent James <kent@caspia.com>
   }
 
   EditorContentListener.prototype = {
-    init : function(aEditor)
+    init(aEditor)
       {
         this.mEditor = aEditor;
       },
@@ -46,7 +46,7 @@ adapted from test_bug607584.xhtml by Kent James <kent@caspia.com>
     QueryInterface: ChromeUtils.generateQI(["nsIWebProgressListener",
                                             "nsISupportsWeakReference"]),
 
-    onStateChange : function(aWebProgress, aRequest, aStateFlags, aStatus)
+    onStateChange(aWebProgress, aRequest, aStateFlags, aStatus)
     {
         if (aStateFlags & Ci.nsIWebProgressListener.STATE_STOP)
         {
@@ -55,7 +55,7 @@ adapted from test_bug607584.xhtml by Kent James <kent@caspia.com>
               this.mEditor.focus();
               editor instanceof Ci.nsIHTMLEditor;
               editor.returnInParagraphCreatesNewParagraph = true;
-              source = "<html><body><table><head></table></body></html>";
+              let source = "<html><body><table><head></table></body></html>";
               editor.rebuildDocumentFromSource(source);
               ok(true, "Don't crash when head appears after body");
               source = "<html></head><head><body></body></html>";
@@ -69,28 +69,28 @@ adapted from test_bug607584.xhtml by Kent James <kent@caspia.com>
     },
   
   
-    onProgressChange : function(aWebProgress, aRequest,
+    onProgressChange(aWebProgress, aRequest,
                                 aCurSelfProgress, aMaxSelfProgress,
                                 aCurTotalProgress, aMaxTotalProgress)
       {
       },
   
-    onLocationChange : function(aWebProgress, aRequest, aLocation, aFlags)
+    onLocationChange(aWebProgress, aRequest, aLocation, aFlags)
       {
       },
   
-    onStatusChange : function(aWebProgress, aRequest, aStatus, aMessage)
+    onStatusChange(aWebProgress, aRequest, aStatus, aMessage)
       {
       },
   
-    onSecurityChange : function(aWebProgress, aRequest, aState)
+    onSecurityChange(aWebProgress, aRequest, aState)
       {
       },
-  
-    onContentBlockingEvent : function(aWebProgress, aRequest, aEvent)
+
+    onContentBlockingEvent(aWebProgress, aRequest, aEvent)
       {
       },
-  
+
       mEditor: null
   };