bug 967629 - don't release any nsNSSShutDownObject in any destructorSafeDestroyNSSReference r=cviecco

security/manager/ssl/src/nsNSSCertCache.cpp

@@ -35,7 +35,6 @@ void nsNSSCertCache::virtualDestroyNSSReference()
 
 void nsNSSCertCache::destructorSafeDestroyNSSReference()
 {
-  mCertList = nullptr;
 }
 
 NS_IMETHODIMP

security/manager/ssl/src/nsNSSShutDown.h

@@ -201,6 +201,11 @@ protected:
   the same lock and checks if objects it cleans up have already cleaned
   up themselves).
 
+  destructorSafeDestroyNSSReference() MUST NOT cause any other
+  nsNSSShutDownObject to be deconstructed. Doing so can cause
+  unsupported concurrent operations on the hash table in the
+  nsNSSShutDownList.
+
   class derivedClass : public nsISomeInterface,
                        public nsNSSShutDownObject
   {

toolkit/identity/IdentityCryptoService.cpp

@@ -156,7 +156,6 @@ private:
 
   void destructorSafeDestroyNSSReference()
   {
-    mKeyPair = nullptr;
   }
 
   const KeyType mKeyType; // in