зеркало из https://github.com/mozilla/gecko-dev.git
servo: Merge #15568 - Fix #15513: Stop spacebar scrolling directly from the glutin window (from samgiles:15513-space-scroll); r=asajeffrey
This completely removes spacebar scrolling using the current method, fixing #15513. See #15513 for a discussion, as the _right thing to do_ is perhaps a UX problem - and perhaps worth a follow up. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15513. No tests for these changes yet, as I'm just kicking off a discussion about how this should work. Source-Repo: https://github.com/servo/servo Source-Revision: eb8d0c3df89e3f51c2610014ab3289eb552f95c9 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 679af1fd093d4a30d9ed36239f13ccb57e9c61a2
This commit is contained in:
Родитель
77f821f58a
Коммит
357b1318d3
|
@ -1042,8 +1042,7 @@ impl WindowMethods for Window {
|
|||
self.event_queue.borrow_mut().push(WindowEvent::Navigation(WindowNavigateMsg::Back));
|
||||
}
|
||||
|
||||
(NONE, None, Key::PageDown) |
|
||||
(NONE, Some(' '), _) => {
|
||||
(NONE, None, Key::PageDown) => {
|
||||
let scroll_location = ScrollLocation::Delta(TypedPoint2D::new(0.0,
|
||||
-self.framebuffer_size()
|
||||
.to_f32()
|
||||
|
@ -1052,8 +1051,7 @@ impl WindowMethods for Window {
|
|||
self.scroll_window(scroll_location,
|
||||
TouchEventType::Move);
|
||||
}
|
||||
(NONE, None, Key::PageUp) |
|
||||
(SHIFT, Some(' '), _) => {
|
||||
(NONE, None, Key::PageUp) => {
|
||||
let scroll_location = ScrollLocation::Delta(TypedPoint2D::new(0.0,
|
||||
self.framebuffer_size()
|
||||
.to_f32()
|
||||
|
|
Загрузка…
Ссылка в новой задаче