Bug 1356033 - chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools r=jdescottes

This is easy to test:

Green tick marks (gcli_sec_good.svg) and Red Crosses (gcli_sec_bad.svg):
1. Go to https://csp-evaluator.withgoogle.com/
2. Shift+F2
3. security csp

I couldn't find a way to show the Orange Minus (gcli_sec_moderate.svg) but the path is changed in line with the other images and I did test it programatically so it will be fine.

MozReview-Commit-ID: 5897IV7epax

--HG--
rename : browser/base/content/gcli_sec_bad.svg => devtools/client/themes/images/gcli_sec_bad.svg
rename : browser/base/content/gcli_sec_good.svg => devtools/client/themes/images/gcli_sec_good.svg
rename : browser/base/content/gcli_sec_moderate.svg => devtools/client/themes/images/gcli_sec_moderate.svg
extra : rebase_source : b550cd4184f2c9e77b1d5df2cf5c67c1296b8ade

browser/base/jar.mn

@@ -117,9 +117,6 @@ browser.jar:
         content/browser/defaultthemes/compact.header.png    (content/defaultthemes/compact.header.png)
         content/browser/defaultthemes/compactdark.icon.svg  (content/defaultthemes/compactdark.icon.svg)
         content/browser/defaultthemes/compactlight.icon.svg (content/defaultthemes/compactlight.icon.svg)
-        content/browser/gcli_sec_bad.svg              (content/gcli_sec_bad.svg)
-        content/browser/gcli_sec_good.svg             (content/gcli_sec_good.svg)
-        content/browser/gcli_sec_moderate.svg         (content/gcli_sec_moderate.svg)
         content/browser/newtab/newTab.xhtml           (content/newtab/newTab.xhtml)
 *       content/browser/newtab/newTab.js              (content/newtab/newTab.js)
         content/browser/newtab/newTab.css             (content/newtab/newTab.css)

devtools/client/jar.mn

@@ -212,6 +212,9 @@ devtools.jar:
     skin/images/debugging-addons.svg (themes/images/debugging-addons.svg)
     skin/images/debugging-tabs.svg (themes/images/debugging-tabs.svg)
     skin/images/debugging-workers.svg (themes/images/debugging-workers.svg)
+    skin/images/gcli_sec_bad.svg (themes/images/gcli_sec_bad.svg)
+    skin/images/gcli_sec_good.svg (themes/images/gcli_sec_good.svg)
+    skin/images/gcli_sec_moderate.svg (themes/images/gcli_sec_moderate.svg)
     skin/images/globe.svg (themes/images/globe.svg)
     skin/images/tool-options.svg (themes/images/tool-options.svg)
     skin/images/tool-webconsole.svg (themes/images/tool-webconsole.svg)

devtools/shared/gcli/commands/security.js

@@ -16,9 +16,9 @@
 const { Ci } = require("chrome");
 const l10n = require("gcli/l10n");
 
-const GOOD_IMG_SRC = "chrome://browser/content/gcli_sec_good.svg";
-const MOD_IMG_SRC = "chrome://browser/content/gcli_sec_moderate.svg";
-const BAD_IMG_SRC = "chrome://browser/content/gcli_sec_bad.svg";
+const GOOD_IMG_SRC = "chrome://devtools/skin/images/gcli_sec_good.svg";
+const MOD_IMG_SRC = "chrome://devtools/skin/images/gcli_sec_moderate.svg";
+const BAD_IMG_SRC = "chrome://devtools/skin/images/gcli_sec_bad.svg";
 
 // special handling within policy
 const POLICY_REPORT_ONLY = "report-only";
@@ -153,7 +153,7 @@ exports.items = [
           html:
             "<table class='gcli-csp-detail' cellspacing='10' valign='top'>" +
             "  <tr>" +
-            "    <td> <img src='chrome://browser/content/gcli_sec_bad.svg' width='20px' /> </td> " +
+            "    <td> <img src='" + BAD_IMG_SRC + "' width='20px' /> </td> " +
             "    <td>" + NO_CSP_ON_PAGE_MSG + " <b>" + url + "</b></td>" +
             "  </tr>" +
             "</table>"});