Bug 1729329 - Mark txStylesheetCompilerState::pushSorter as infallible. r=farre

Differential Revision: https://phabricator.services.mozilla.com/D124672

dom/xslt/xslt/txStylesheetCompileHandlers.cpp

@@ -1185,14 +1185,11 @@ static nsresult txFnStartApplyTemplates(int32_t aNamespaceID,
 
   UniquePtr<txPushNewContext> pushcontext(
       new txPushNewContext(std::move(select)));
-  rv = aState.pushSorter(pushcontext.get());
-  NS_ENSURE_SUCCESS(rv, rv);
+  aState.pushSorter(pushcontext.get());
 
-  rv = aState.pushObject(pushcontext.get());
+  rv = aState.pushObject(pushcontext.release());
   NS_ENSURE_SUCCESS(rv, rv);
 
-  Unused << pushcontext.release();
-
   aState.pushHandlerTable(gTxApplyTemplatesHandler);
 
   return NS_OK;
@@ -1535,9 +1532,7 @@ static nsresult txFnStartForEach(int32_t aNamespaceID, nsAtom* aLocalName,
   UniquePtr<txPushNewContext> pushcontext(
       new txPushNewContext(std::move(select)));
   aState.pushPtr(pushcontext.get(), aState.ePushNewContext);
-
-  rv = aState.pushSorter(pushcontext.get());
-  NS_ENSURE_SUCCESS(rv, rv);
+  aState.pushSorter(pushcontext.get());
 
   aState.addInstruction(std::move(pushcontext));
 

dom/xslt/xslt/txStylesheetCompiler.cpp

@@ -537,11 +537,9 @@ void txStylesheetCompilerState::popHandlerTable() {
   mHandlerTable = static_cast<txHandlerTable*>(popPtr(eHandlerTable));
 }
 
-nsresult txStylesheetCompilerState::pushSorter(txPushNewContext* aSorter) {
+void txStylesheetCompilerState::pushSorter(txPushNewContext* aSorter) {
   pushPtr(mSorter, ePushNewContext);
   mSorter = aSorter;
-
-  return NS_OK;
 }
 
 void txStylesheetCompilerState::popSorter() {

dom/xslt/xslt/txStylesheetCompiler.h

@@ -89,7 +89,7 @@ class txStylesheetCompilerState : public txIParseContext {
   };
   void pushHandlerTable(txHandlerTable* aTable);
   void popHandlerTable();
-  nsresult pushSorter(txPushNewContext* aSorter);
+  void pushSorter(txPushNewContext* aSorter);
   void popSorter();
   nsresult pushChooseGotoList();
   void popChooseGotoList();