Bug 1692097 - Remove remaining X.setAttribute("hidden", "true") references from devtools/client. r=nchevobbe

Differential Revision: https://phabricator.services.mozilla.com/D104774

devtools/client/framework/devtools-browser.js

@@ -646,14 +646,7 @@ var gDevToolsBrowser = (exports.gDevToolsBrowser = {
     const menu = win.document.getElementById("menu_devToolbox");
 
     // Hide the "Toggle Tools" menu item if we are on about:devtools-toolbox.
-    const isAboutDevtoolsToolbox = gDevToolsBrowser._isAboutDevtoolsToolbox(
-      win
-    );
-    if (isAboutDevtoolsToolbox) {
-      menu.setAttribute("hidden", "true");
-    } else {
-      menu.removeAttribute("hidden");
-    }
+    menu.hidden = gDevToolsBrowser._isAboutDevtoolsToolbox(win);
 
     // Add a checkmark for the "Toggle Tools" menu item if a toolbox is already opened.
     const hasToolbox = gDevToolsBrowser.hasToolboxOpened(win);

devtools/client/storage/test/head.js

@@ -814,12 +814,7 @@ function checkCellUneditable(id, column) {
 function showColumn(id, state) {
   const columns = gUI.table.columns;
   const column = columns.get(id);
-
-  if (state) {
-    column.wrapper.removeAttribute("hidden");
-  } else {
-    column.wrapper.setAttribute("hidden", true);
-  }
+  column.wrapper.hidden = !state;
 }
 
 /**