coverity-found potential use-after-free in testcases (bug 334541). r=bsmedberg

xpcom/tests/TestCOMPtr.cpp

@@ -155,24 +155,21 @@ IFoo::AddRef()
 nsrefcnt
 IFoo::Release()
   {
-    int wrap_message = (refcount_ == 1);
+    int newcount = --refcount_;
-    if ( wrap_message )
+    if ( newcount == 0 )
       printf(">>");
-      
+
-    --refcount_;
     printf("IFoo@%p::Release(), refcount --> %d\n",
            STATIC_CAST(void*, this), refcount_);
 
-    if ( !refcount_ )
+    if ( newcount == 0 )
       {
         printf("  delete IFoo@%p\n", STATIC_CAST(void*, this));
+        printf("<<IFoo@%p::Release()\n", STATIC_CAST(void*, this));
         delete this;
       }
 
-    if ( wrap_message )
+    return newcount;
-      printf("<<IFoo@%p::Release()\n", STATIC_CAST(void*, this));
-
-    return refcount_;
   }
 
 nsresult

xpcom/tests/TestHashtables.cpp

@@ -288,24 +288,21 @@ IFoo::AddRef()
 nsrefcnt
 IFoo::Release()
   {
-    int wrap_message = (refcount_ == 1);
+    int newcount = --refcount_;
-    if ( wrap_message )
+    if ( newcount == 0 )
       printf(">>");
-      
+
-    --refcount_;
     printf("IFoo@%p::Release(), refcount --> %d\n",
            NS_STATIC_CAST(void*, this), refcount_);
 
-    if ( !refcount_ )
+    if ( newcount == 0 )
       {
         printf("  delete IFoo@%p\n", NS_STATIC_CAST(void*, this));
+        printf("<<IFoo@%p::Release()\n", NS_STATIC_CAST(void*, this));
         delete this;
       }
 
-    if ( wrap_message )
+    return newcount;
-      printf("  delete IFoo@%p\n", NS_STATIC_CAST(void*, this));
-
-    return refcount_;
   }
 
 nsresult