Bug 1701460 - Remove expired Telemetry probe security.client_cert r=keeler

Differential Revision: https://phabricator.services.mozilla.com/D110496

security/manager/ssl/nsNSSIOLayer.cpp

@@ -1876,9 +1876,6 @@ SECStatus nsNSS_SSLGetClientAuthData(void* arg, PRFileDesc* socket,
   *pRetCert = nullptr;
   *pRetKey = nullptr;
 
-  Telemetry::ScalarAdd(Telemetry::ScalarID::SECURITY_CLIENT_CERT,
-                       u"requested"_ns, 1);
-
   RefPtr<nsNSSSocketInfo> info(
       BitwiseCast<nsNSSSocketInfo*, PRFilePrivate*>(socket->higher->secret));
 
@@ -1937,8 +1934,6 @@ SECStatus nsNSS_SSLGetClientAuthData(void* arg, PRFileDesc* socket,
     *pRetKey = selectedKey.release();
     // Make joinConnection prohibit joining after we've sent a client cert
     info->SetSentClientCert();
-    Telemetry::ScalarAdd(Telemetry::ScalarID::SECURITY_CLIENT_CERT, u"sent"_ns,
-                         1);
     if (info->GetSSLVersionUsed() == nsISSLSocketControl::TLS_VERSION_1_3) {
       Telemetry::Accumulate(Telemetry::TLS_1_3_CLIENT_AUTH_USES_PHA,
                             info->IsHandshakeCompleted());

toolkit/components/telemetry/Scalars.yaml

@@ -1216,25 +1216,6 @@ security:
       - 'firefox'
     record_in_processes:
       - main
-  client_cert:
-    bug_numbers:
-      - 1255120
-    description: >
-      Counts of events related to client certificates this session. Currently:
-      "requested" (a server requested a client certificate), "sent" (a client
-      certificate was sent), "compat" (a compatibility workaround was required).
-    expires: "66"
-    kind: uint
-    keyed: true
-    notification_emails:
-      - seceng-telemetry@mozilla.com
-      - dkeeler@mozilla.com
-    release_channel_collection: opt-out
-    products:
-      - 'firefox'
-      - 'fennec'
-    record_in_processes:
-      - main
   https_only_mode_enabled:
     bug_numbers:
       - 1620244