Bug 402104 - Places Organizer window misses accesskeys. Patch by Cedric Corazza, r=me.

browser/components/places/content/editBookmarkOverlay.xul

@@ -60,6 +60,7 @@
       <rows>
         <row align="center" id="editBMPanel_nameRow">
           <label value="&editBookmarkOverlay.name.label;"
+                 accesskey="&editBookmarkOverlay.name.accesskey;"
                  control="editBMPanel_namePicker"
                  observes="paneElementsBroadcaster"/>
           <menulist id="editBMPanel_namePicker"
@@ -82,6 +83,7 @@
 
         <row align="center" id="editBMPanel_locationRow">
           <label value="&editBookmarkOverlay.location.label;"
+                 accesskey="&editBookmarkOverlay.location.accesskey;"
                  control="editBMPanel_locationField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_locationField"
@@ -91,6 +93,7 @@
 
         <row align="center" id="editBMPanel_feedLocationRow">
           <label value="&editBookmarkOverlay.feedLocation.label;"
+                 accesskey="&editBookmarkOverlay.feedLocation.accesskey;"
                  control="editBMPanel_feedLocationField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_feedLocationField"
@@ -100,6 +103,7 @@
 
         <row align="center" id="editBMPanel_siteLocationRow">
           <label value="&editBookmarkOverlay.siteLocation.label;"
+                 accesskey="&editBookmarkOverlay.siteLocation.accesskey;"
                  control="editBMPanel_siteLocationField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_siteLocationField"
@@ -151,6 +155,7 @@
 
         <row align="center" id="editBMPanel_tagsRow">
           <label value="&editBookmarkOverlay.tags.label;"
+                 accesskey="&editBookmarkOverlay.tags.accesskey;"
                  control="editBMPanel_tagsField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_tagsField"
@@ -171,6 +176,7 @@
 
         <row id="editBMPanel_keywordRow">
           <label value="&editBookmarkOverlay.keyword.label;"
+                 accesskey="&editBookmarkOverlay.keyword.accesskey;"
                  control="editBMPanel_keywordField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_keywordField"
@@ -180,6 +186,7 @@
 
         <row id="editBMPanel_descriptionRow">
           <label value="&editBookmarkOverlay.description.label;"
+                 accesskey="&editBookmarkOverlay.description.accesskey;"
                  control="editBMPanel_descriptionField"
                  observes="paneElementsBroadcaster"/>
           <textbox id="editBMPanel_descriptionField"
@@ -189,6 +196,7 @@
         </row>
         <checkbox id="editBMPanel_loadInSidebarCheckbox"
                   label="&editBookmarkOverlay.loadInSidebar.label;"
+                  accesskey="&editBookmarkOverlay.loadInSidebar.accesskey;"
                   oncommand="gEditItemOverlay.onLoadInSidebarCheckboxCommand();"
                   observes="paneElementsBroadcaster"/>
       </rows>

browser/components/places/content/places.js

@@ -614,10 +614,12 @@ var PlacesOrganizer = {
     if (infoScrollbox.getAttribute("minimal") == "true") {
       infoScrollbox.removeAttribute("minimal");
       scrollboxExpander.label = scrollboxExpander.getAttribute("lesslabel");
+      scrollboxExpander.accessKey = scrollboxExpander.getAttribute("lessaccesskey");
     }
     else {
       infoScrollbox.setAttribute("minimal", "true");
       scrollboxExpander.label = scrollboxExpander.getAttribute("morelabel");
+      scrollboxExpander.accessKey = scrollboxExpander.getAttribute("moreaccesskey");
     }
   },
 

browser/components/places/content/places.xul

@@ -452,8 +452,11 @@
                   <hbox>
                     <button type="image" id="infoScrollboxExpander"
                             lesslabel="&detailsPane.less.label;"
+                            lessaccesskey="&detailsPane.less.accesskey;"
                             morelabel="&detailsPane.more.label;"
+                            moreaccesskey="&detailsPane.more.accesskey;"
                             label="&detailsPane.more.label;"
+                            accesskey="&detailsPane.more.accesskey;"
                             oncommand="PlacesOrganizer.toggleAdditionalInfoFields();"
                             observes="paneElementsBroadcaster"/>
                     <spacer flex="1"/>

browser/locales/en-US/chrome/browser/places/editBookmarkOverlay.dtd

@@ -1,13 +1,21 @@
 <!ENTITY editBookmarkOverlay.name.label                      "Name:">
+<!ENTITY editBookmarkOverlay.name.accesskey                  "N">
 <!ENTITY editBookmarkOverlay.location.label                  "Location:">
+<!ENTITY editBookmarkOverlay.location.accesskey              "L">
 <!ENTITY editBookmarkOverlay.feedLocation.label              "Feed Location:">
+<!ENTITY editBookmarkOverlay.feedLocation.accesskey          "F">
 <!ENTITY editBookmarkOverlay.siteLocation.label              "Site Location:">
+<!ENTITY editBookmarkOverlay.siteLocation.accesskey          "S">
 <!ENTITY editBookmarkOverlay.liveTitlesSeparator.label       "Live Titles">
 <!ENTITY editBookmarkOverlay.folder.label                    "Folder:">
 <!ENTITY editBookmarkOverlay.foldersExpanderDown.tooltip     "Show all the bookmarks folders">
 <!ENTITY editBookmarkOverlay.expanderUp.tooltip              "Hide">
 <!ENTITY editBookmarkOverlay.tags.label                      "Tags:">
+<!ENTITY editBookmarkOverlay.tags.accesskey                  "T">
 <!ENTITY editBookmarkOverlay.description.label               "Description:">
+<!ENTITY editBookmarkOverlay.description.accesskey           "D">
 <!ENTITY editBookmarkOverlay.keyword.label                   "Keyword:">
+<!ENTITY editBookmarkOverlay.keyword.accesskey               "K">
 <!ENTITY editBookmarkOverlay.tagsExpanderDown.tooltip        "Show all tags">
 <!ENTITY editBookmarkOverlay.loadInSidebar.label             "Load this bookmark in the sidebar">
+<!ENTITY editBookmarkOverlay.loadInSidebar.accesskey         "h">

browser/locales/en-US/chrome/browser/places/places.dtd

@@ -204,6 +204,8 @@
 <!ENTITY forwardButton.tooltip  "Go forward">
 
 <!ENTITY detailsPane.more.label "More">
+<!ENTITY detailsPane.more.accesskey "e">
 <!ENTITY detailsPane.less.label "Less">
+<!ENTITY detailsPane.less.accesskey "e">
 <!ENTITY detailsPane.noPreviewAvailable.label "Preview">
 <!ENTITY detailsPane.selectAnItemText.description "Select an item to view and edit its properties">