Bug 697076 - Fix some Clang warnings. r=luke

js/src/editline/editline.c

@@ -1002,6 +1002,7 @@ void
 rl_reset_terminal(p)
     char	*p;
 {
+    (void)p;
 }
 
 void

js/src/jsinfer.cpp

@@ -347,7 +347,7 @@ types::TypeFailure(JSContext *cx, const char *fmt, ...)
     /* Always active, even in release builds */
     JS_Assert(msgbuf, __FILE__, __LINE__);
     
-    *((int*)NULL) = 0;  /* Should never be reached */
+    *((volatile int *)NULL) = 0;  /* Should never be reached */
 }
 
 /////////////////////////////////////////////////////////////////////

js/src/jsutil.cpp

@@ -82,14 +82,14 @@ CrashInJS()
      * We used to call DebugBreak() on Windows, but amazingly, it causes
      * the MSVS 2010 debugger not to be able to recover a call stack.
      */
-    *((int *) NULL) = 123;
+    *((volatile int *) NULL) = 123;
     exit(3);
 #elif defined(__APPLE__)
     /*
      * On Mac OS X, Breakpad ignores signals. Only real Mach exceptions are
      * trapped.
      */
-    *((int *) NULL) = 123;  /* To continue from here in GDB: "return" then "continue". */
+    *((volatile int *) NULL) = 123;  /* To continue from here in GDB: "return" then "continue". */
     raise(SIGABRT);  /* In case above statement gets nixed by the optimizer. */
 #else
     raise(SIGABRT);  /* To continue from here in GDB: "signal 0". */

js/src/jswrapper.cpp

@@ -877,5 +877,5 @@ SecurityWrapper<Base>::objectClassIs(JSObject *obj, ESClassValue classValue, JSC
     return ret;
 }
 
-template class SecurityWrapper<Wrapper>;
-template class SecurityWrapper<CrossCompartmentWrapper>;
+template class js::SecurityWrapper<Wrapper>;
+template class js::SecurityWrapper<CrossCompartmentWrapper>;

js/src/v8-dtoa/platform.cc

@@ -66,14 +66,14 @@ void OS::Abort() {
      * We used to call DebugBreak() on Windows, but amazingly, it causes
      * the MSVS 2010 debugger not to be able to recover a call stack.
      */
-    *((int *) NULL) = 0;
+    *((volatile int *) NULL) = 0;
     exit(3);
 #elif defined(__APPLE__)
     /*
      * On Mac OS X, Breakpad ignores signals. Only real Mach exceptions are
      * trapped.
      */
-    *((int *) NULL) = 0;  /* To continue from here in GDB: "return" then "continue". */
+    *((volatile int *) NULL) = 0;  /* To continue from here in GDB: "return" then "continue". */
     raise(SIGABRT);  /* In case above statement gets nixed by the optimizer. */
 #else
     raise(SIGABRT);  /* To continue from here in GDB: "signal 0". */