mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1535507 - Assume that we have an empty display list building override rect for frames that support it, even if an explicit one isn't present. r=miko 

If the frame supports it (stacking context + containing block for fixed), and a descendant was
modified, we would have created an override dirty region with just the area of that descendant.
In the case where no descendants are modified, we should use an empty rect, rather than
the area inherited from our parent.

This fixes the case where we forcibly build position:fixed frames (since they might async
scroll differently to the rest of the page), but we only need to build the container item,
not the whole frame subtree within it.

Added a test that shows us building the non-intersecting position:fixed, but not items within it.

Differential Revision: https://phabricator.services.mozilla.com/D23610

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Matt Woodrow 2019-03-26 02:14:50 +00:00
Родитель bb2fb955d4
Коммит 3859e5d739
4 изменённых файлов: 65 добавлений и 9 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

24
layout/generic/nsFrame.cpp
Просмотреть файл

@ -2964,15 +2964,21 @@ void nsIFrame::BuildDisplayListForStackingContext(
} }
bool hasOverrideDirtyRect = false; bool hasOverrideDirtyRect = false;
// If we have an override dirty region, and neither us nor our ancestors are // If we're doing a partial build, we're not invalid and we're capable
// modified, then use it. // of having an override building rect (stacking context and fixed pos
if (HasOverrideDirtyRegion() && !aBuilder->InInvalidSubtree() && // containing block), then we should assume we have one.
!IsFrameModified()) { // Either we have an explicit one, or nothing in our subtree changed and
nsDisplayListBuilder::DisplayListBuildingData* data = // we have an implicit empty rect.
GetProperty(nsDisplayListBuilder::DisplayListBuildingRect()); if (aBuilder->IsPartialUpdate() && !aBuilder->InInvalidSubtree() &&
if (data) { !IsFrameModified() && IsFixedPosContainingBlock()) {
dirtyRect = data->mDirtyRect.Intersect(visibleRect); dirtyRect = nsRect();
hasOverrideDirtyRect = true; if (HasOverrideDirtyRegion()) {
nsDisplayListBuilder::DisplayListBuildingData* data =
GetProperty(nsDisplayListBuilder::DisplayListBuildingRect());
if (data) {
dirtyRect = data->mDirtyRect.Intersect(visibleRect);
hasOverrideDirtyRect = true;
}
} }
} }

1
layout/reftests/display-list/reftest.list
Просмотреть файл

@ -3,6 +3,7 @@ skip-if(!retainedDisplayList) == retained-dl-frame-deleted-1.html retained-dl-st
skip-if(!retainedDisplayList) == retained-dl-frame-created-1.html retained-dl-style-change-1-ref.html skip-if(!retainedDisplayList) == retained-dl-frame-created-1.html retained-dl-style-change-1-ref.html
skip-if(!retainedDisplayList) == retained-dl-style-change-stacking-context-1.html retained-dl-style-change-stacking-context-1-ref.html skip-if(!retainedDisplayList) == retained-dl-style-change-stacking-context-1.html retained-dl-style-change-stacking-context-1-ref.html
skip-if(!retainedDisplayList) == retained-dl-style-change-stacking-context-2.html retained-dl-style-change-stacking-context-2-ref.html skip-if(!retainedDisplayList) == retained-dl-style-change-stacking-context-2.html retained-dl-style-change-stacking-context-2-ref.html
skip-if(!retainedDisplayList) == retained-dl-style-change-stacking-context-3.html retained-dl-style-change-stacking-context-3-ref.html
skip-if(!retainedDisplayList||!asyncPan) == retained-dl-async-scrolled-1.html retained-dl-async-scrolled-1-ref.html skip-if(!retainedDisplayList||!asyncPan) == retained-dl-async-scrolled-1.html retained-dl-async-scrolled-1-ref.html
skip-if(!retainedDisplayList) == retained-dl-remove-for-ancestor-change-1.html retained-dl-remove-for-ancestor-change-1-ref.html skip-if(!retainedDisplayList) == retained-dl-remove-for-ancestor-change-1.html retained-dl-remove-for-ancestor-change-1-ref.html
skip-if(!retainedDisplayList) == retained-dl-scroll-out-of-view-1.html retained-dl-scroll-out-of-view-1-ref.html skip-if(!retainedDisplayList) == retained-dl-scroll-out-of-view-1.html retained-dl-scroll-out-of-view-1-ref.html

20
layout/reftests/display-list/retained-dl-style-change-stacking-context-3-ref.html Normal file
Просмотреть файл

@ -0,0 +1,20 @@
<html>
<head>
<style>
body {
margin: 0px;
}
div {
width:100px;
height:100px;
display: inline-block;
position:absolute;
background-color: green;
}
</style>
</head>
<body>
<div></div>
<div style="top: 110px;"></div>
</body>
</html>

29
layout/reftests/display-list/retained-dl-style-change-stacking-context-3.html Normal file
Просмотреть файл

@ -0,0 +1,29 @@
<html class="reftest-wait">
<head>
<style>
body {
margin: 0px;
}
div {
width:100px;
height:100px;
display: inline-block;
position:absolute;
}
</style>
</head>
<body>
<div style="position:fixed;" class="reftest-display-list">
<div style="background-color:green;" class="reftest-no-display-list">
</div>
<div id="second" style="background-color:red; top: 110px;"></div>
</body>
<script>
function doTest() {
document.getElementById("second").style.backgroundColor = "green";
document.documentElement.removeAttribute("class");
}
window.addEventListener("MozReftestInvalidate", doTest);
</script>
</html>