From 385f79fdcf7d97a16eef19b27721c172c3210897 Mon Sep 17 00:00:00 2001 From: Jon Coppeard Date: Tue, 8 Aug 2023 08:36:03 +0000 Subject: [PATCH] Bug 1846270 - Fix parallel marking utilization telemetry broken by previous patch in this bug r=sfink My previous patch changed the way |parallelRunTime| is calculated by adding waiting time where it was previously subtracted. The utilization telemetry is meant to show the fraction of time the helper threads spent running so waiting time should not be included. Differential Revision: https://phabricator.services.mozilla.com/D185578 --- js/src/gc/Statistics.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/js/src/gc/Statistics.cpp b/js/src/gc/Statistics.cpp index 133aa2c72669..2166e2d75edf 100644 --- a/js/src/gc/Statistics.cpp +++ b/js/src/gc/Statistics.cpp @@ -1127,8 +1127,7 @@ void Statistics::sendGCTelemetry() { TimeDuration parallelMarkTime = sumTotalParallelTime(PhaseKind::PARALLEL_MARK_MARK); TimeDuration parallelRunTime = - parallelMarkTime + sumTotalParallelTime(PhaseKind::PARALLEL_MARK_WAIT) + - sumTotalParallelTime(PhaseKind::PARALLEL_MARK_OTHER); + parallelMarkTime + sumTotalParallelTime(PhaseKind::PARALLEL_MARK_OTHER); if (wallTime && parallelMarkTime) { uint32_t threadCount = gc->markers.length(); double speedup = parallelMarkTime / wallTime;