mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1608923 - reuse some DTD strings so at least play/pause and the mute/unmute button are labeled, r=mconley 

Differential Revision: https://phabricator.services.mozilla.com/D60199

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Gijs Kruitbosch 2020-01-20 19:26:15 +00:00
Родитель 96ed25174f
Коммит 399ccaf394
2 изменённых файлов: 19 добавлений и 6 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

8
toolkit/components/pictureinpicture/content/player.js
Просмотреть файл

@ -277,6 +277,10 @@ let Player = {
set isPlaying(isPlaying) {
this._isPlaying = isPlaying;
this.controls.classList.toggle("playing", isPlaying);
const playButton = document.getElementById("playpause");
let attrName = isPlaying ? "pauselabel" : "playlabel";
let accessibleLabel = playButton.getAttribute(attrName);
playButton.setAttribute("aria-label", accessibleLabel);
},
_isMuted: false,
@ -296,6 +300,10 @@ let Player = {
set isMuted(isMuted) {
this._isMuted = isMuted;
this.controls.classList.toggle("muted", isMuted);
const audioButton = document.getElementById("audio");
let attrName = isMuted ? "unmutelabel" : "mutelabel";
let accessibleLabel = audioButton.getAttribute(attrName);
audioButton.setAttribute("aria-label", accessibleLabel);
},
recordEvent(type, args) {

17
toolkit/components/pictureinpicture/content/player.xhtml
Просмотреть файл

@ -1,11 +1,12 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE system [
<!ENTITY % videocontrolsDTD
SYSTEM "chrome://global/locale/videocontrols.dtd">
%videocontrolsDTD;
]>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<!DOCTYPE html [
<!ENTITY % htmlDTD PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "DTD/xhtml1-strict.dtd">
%htmlDTD;
]>
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
windowtype="Toolkit:PictureInPicture"
@ -29,9 +30,13 @@
<div id="controls-bottom">
<button id="unpip" class="control-item" tabindex="2"></button>
<div class="gap"></div>
<button id="playpause" class="control-item" tabindex="1" autofocus="true"></button>
<button id="playpause" class="control-item" tabindex="1" autofocus="true"
playlabel="&playButton.playLabel;"
pauselabel="&playButton.pauseLabel;"/>
<div class="gap" hidden="true"></div>
<button id="audio" class="control-item" hidden="true" tabindex="1"></button>
<button id="audio" class="control-item" hidden="true" tabindex="1"
mutelabel="&muteButton.muteLabel;"
unmutelabel="&muteButton.unmuteLabel;"/>
</div>
</div>
</body>