Bug 1855697 - Enable ESLint rule no-implied-eval for all of dom/. r=dom-core,edgar

Depends on D189496

Differential Revision: https://phabricator.services.mozilla.com/D189497

.eslintrc.js

@@ -448,7 +448,6 @@ module.exports = {
         "no-empty": "off",
         "no-func-assign": "off",
         "no-global-assign": "off",
-        "no-implied-eval": "off",
         "no-lone-blocks": "off",
         "no-lonely-if": "off",
         "no-nested-ternary": "off",

dom/base/test/file_settimeout_inner.html

@@ -1 +1,6 @@
-<script>window.onload = function runTest1() { document.open(); setTimeout('parent.test1Done();'); document.close(); }</script>
+<script>window.onload = function runTest1() {
+  document.open();
+  // eslint-disable-next-line no-implied-eval
+  setTimeout('parent.test1Done();');
+  document.close();
+}</script>

dom/base/test/test_bug1100912.html

@@ -18,7 +18,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1100912
   }
 
   function didRunTests() {
-    setTimeout("SimpleTest.finish()");
+    setTimeout(SimpleTest.finish);
   }
 
   </script>

dom/base/test/test_bug435425.html

@@ -414,7 +414,7 @@ function runTest() {
 
 function nextTest() {
   if (tests.length) {
-    setTimeout("runTest()", 0);
+    setTimeout(runTest, 0);
   } else {
     SimpleTest.finish();
   }

dom/base/test/test_bug557892.html

@@ -25,7 +25,7 @@ window.open("file_bug557892.html", "", "width=100,height=100");
 
 function done() {
   ok(true, "Should not crash");
-  setTimeout("SimpleTest.finish();", 0);
+  setTimeout(SimpleTest.finish, 0);
 }
 
 </script>

dom/base/test/test_focus_shadow_dom.html

@@ -23,7 +23,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1453693
   }
 
   function didRunTests() {
-    setTimeout("SimpleTest.finish()");
+    setTimeout(SimpleTest.finish);
   }
 
   ;

dom/base/test/test_setTimeoutWith0.html

@@ -8,6 +8,7 @@
 <script>
 
 var x = 0;
+// eslint-disable-next-line no-implied-eval
 setTimeout("x++; '\x00'; x++;");
 setTimeout(function() {
   is(x, 2, "We want to see 2 here");

dom/base/test/test_settimeout_extra_arguments.html

@@ -7,6 +7,8 @@
 <script>
   t1 = async_test("setTimeout with more than 2 arguments, first argument a string, should work");
   t2 = async_test("setInterval with more than 2 arguments, first argument a string, should work");
+  // eslint-disable-next-line no-implied-eval
   setTimeout("t1.done()", 0, {});
+  // eslint-disable-next-line no-implied-eval
   var interval = setInterval("clearInterval(interval); t2.done()", 0, {});
 </script>

dom/events/test/test_bug1429572.html

@@ -26,7 +26,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1429572
   }
 
   function done() {
-    setTimeout("SimpleTest.finish();");
+    setTimeout(SimpleTest.finish);
   }
 
   </script>

dom/events/test/test_bug1447993.html

@@ -24,7 +24,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1447993
   }
 
   function done() {
-    setTimeout("SimpleTest.finish();");
+    setTimeout(SimpleTest.finish);
   }
 
   </script>

dom/events/test/test_bug447736.html

@@ -27,6 +27,7 @@ window.addEventListener("load",
     is(evt.originalTarget, window.document, "Wrong originalTarget!");
     ok(evt.isTrusted, "Event should be trusted!");
     loadEvent = evt;
+    // eslint-disable-next-line no-implied-eval
     setTimeout("st.dispatchEvent(loadEvent)", 0);
   }, true);
 

dom/events/test/test_bug489671.html

@@ -33,6 +33,7 @@ function doTest() {
       document.body.appendChild(script);
       break;
     case 2:
+      // eslint-disable-next-line no-implied-eval
       window.setTimeout("queueNextTest(); throw 'Got click 3'", 0);
       break;
     case 3:

dom/events/test/test_coalesce_mousewheel.html

@@ -229,7 +229,7 @@
     await testManySingleWheelEvents();
     await testMixedWheelEvents();
 
-    setTimeout("SimpleTest.finish()");
+    setTimeout(SimpleTest.finish);
     window.close();
   }
 

dom/html/test/test_bug567938-3.html

@@ -39,6 +39,7 @@ function initializeNextTest()
   var element = document.createElement("input");
   element.id = 'i';
   element.type = gTestData[gCurrentTest];
+  // eslint-disable-next-line no-implied-eval
   element.onclick = function() { setTimeout("document.forms[0].submit();",0); return false; };
   form.appendChild(element);
   form.action = gTestData[gCurrentTest];

dom/media/webaudio/test/test_bug875221.html

@@ -8,6 +8,7 @@
 <body>
 <pre id="test">
 <script class="testbody" type="text/javascript">
+/* eslint-disable no-implied-eval */
 
 SimpleTest.waitForExplicitFinish();
 SimpleTest.requestFlakyTimeout("This test is generated by a fuzzer, so we leave these setTimeouts untouched.");

dom/media/webaudio/test/test_bug875402.html

@@ -8,6 +8,7 @@
 <body>
 <pre id="test">
 <script class="testbody" type="text/javascript">
+/* eslint-disable no-implied-eval */
 
 SimpleTest.waitForExplicitFinish();
 

dom/security/test/csp/file_evalscript_main.js

@@ -73,6 +73,7 @@ addEventListener(
         }
       }
       setTimeout(fcn_setTimeoutWithStringCheck.bind(window), 10);
+      // eslint-disable-next-line no-implied-eval
       var res = setTimeout(str_setTimeoutWithStringRan, 10);
       verifyZeroRetVal(res, "setTimeout(String)");
     }
@@ -92,6 +93,7 @@ addEventListener(
         }
       }
       setTimeout(fcn_setIntervalWithStringCheck.bind(window), 10);
+      // eslint-disable-next-line no-implied-eval
       var res = setInterval(str_setIntervalWithStringRan, 10);
       verifyZeroRetVal(res, "setInterval(String)");
 

dom/security/test/csp/file_evalscript_main_allowed.js

@@ -45,6 +45,7 @@ addEventListener(
   function () {
     // setTimeout(String) test  -- should pass
     try {
+      // eslint-disable-next-line no-implied-eval
       setTimeout(
         'onevalexecuted(true, "setTimeout(String)", "setTimeout with a string was enabled.");',
         10

dom/workers/test/threadTimeouts_worker.js

@@ -34,6 +34,7 @@ function messageListener(event) {
       postMessage("intervalCanceled");
       break;
     case "startExpression":
+      // eslint-disable-next-line no-implied-eval
       setTimeout("this.postMessage('expressionFinished');", 2000);
       break;
     default:

dom/workers/test/timeoutTracing_worker.js

@@ -10,6 +10,7 @@ onmessage = function (event) {
 setInterval(function () {
   postMessage("Still alive!");
 }, 20);
+// eslint-disable-next-line no-implied-eval
 setInterval(";", 20);
 
 postMessage("Begin!");

dom/workers/test/worker_setTimeoutWith0.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-implied-eval */
 var x = 0;
 setTimeout("x++; '\x00'; x++;");
 setTimeout("postMessage(x);");