From 3ad07f32b9edac0c9d2ab653a0e10405c05e6da0 Mon Sep 17 00:00:00 2001 From: Thi Huynh Date: Mon, 10 Sep 2018 16:08:10 +0000 Subject: [PATCH] Bug 1485695 - Remove unused uptime property from the main ping. r=Dexter Differential Revision: https://phabricator.services.mozilla.com/D4296 --HG-- extra : moz-landing-system : lando --- toolkit/components/telemetry/docs/data/main-ping.rst | 4 ---- toolkit/components/telemetry/pings/TelemetrySession.jsm | 1 - .../components/telemetry/tests/unit/test_TelemetrySession.js | 1 - 3 files changed, 6 deletions(-) diff --git a/toolkit/components/telemetry/docs/data/main-ping.rst b/toolkit/components/telemetry/docs/data/main-ping.rst index 7effba27023b..ff59a90b7dfe 100644 --- a/toolkit/components/telemetry/docs/data/main-ping.rst +++ b/toolkit/components/telemetry/docs/data/main-ping.rst @@ -149,10 +149,6 @@ totalTime ~~~~~~~~~ A non-monotonic integer representing the number of seconds the session has been alive. -uptime -~~~~~~ -A non-monotonic integer representing the number of minutes the session has been alive. - addonManager ~~~~~~~~~~~~ Only available in the extended set of measures, it contains a set of counters related to Addons. See `here `__ for a list of recorded measures. diff --git a/toolkit/components/telemetry/pings/TelemetrySession.jsm b/toolkit/components/telemetry/pings/TelemetrySession.jsm index 824f738d9662..3a23b67a9f40 100644 --- a/toolkit/components/telemetry/pings/TelemetrySession.jsm +++ b/toolkit/components/telemetry/pings/TelemetrySession.jsm @@ -745,7 +745,6 @@ var Impl = { let elapsedTime = Date.now() - si.process; var ret = { totalTime: Math.round(elapsedTime / 1000), // totalTime, in seconds - uptime: Math.round(elapsedTime / 60000), // uptime in minutes }; // Look for app-specific timestamps diff --git a/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js b/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js index da30473ff62f..c1fe771bcce2 100644 --- a/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js +++ b/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js @@ -280,7 +280,6 @@ function checkPayload(payload, reason, successfulPings) { checkPayloadInfo(payload.info, reason); Assert.ok(payload.simpleMeasurements.totalTime >= 0); - Assert.ok(payload.simpleMeasurements.uptime >= 0); Assert.equal(payload.simpleMeasurements.startupInterrupted, 1); Assert.equal(payload.simpleMeasurements.shutdownDuration, SHUTDOWN_TIME); Assert.ok("maximalNumberOfConcurrentThreads" in payload.simpleMeasurements);