diff --git a/string/obsolete/nsString.h b/string/obsolete/nsString.h index 03fb430869bc..b9bd339ef1e0 100644 --- a/string/obsolete/nsString.h +++ b/string/obsolete/nsString.h @@ -425,8 +425,8 @@ public: * @param aString: string to be added to this * @return this */ - nsCString& operator=(PRUnichar aChar) {return Assign(aChar);} - nsCString& operator=(char aChar) {AssignWithConversion(aChar); return *this;} + nsCString& operator=(PRUnichar aChar) {AssignWithConversion(aChar); return *this;} + nsCString& operator=(char aChar) {return Assign(aChar);} nsCString& operator=(const PRUnichar* aString) {AssignWithConversion(aString); return *this;} nsCString& operator=(const nsCString& aString) {return Assign(aString);} @@ -775,10 +775,10 @@ public: private: // NOT TO BE IMPLEMENTED // these signatures help clients not accidentally call the wrong thing helped by C++ automatic integral promotion - void AssignWithConversion( char ) { } - void AssignWithConversion( const char*, PRInt32=-1 ) { } - void AppendWithConversion( char ) { } - void InsertWithConversion( char, PRUint32 ) { } + void AssignWithConversion( char ); + void AssignWithConversion( const char*, PRInt32=-1 ); + void AppendWithConversion( char ); + void InsertWithConversion( char, PRUint32 ); }; #if 0//def NEW_STRING_APIS diff --git a/string/obsolete/nsString2.h b/string/obsolete/nsString2.h index 4e0d313fa8af..bafcb690f3e1 100644 --- a/string/obsolete/nsString2.h +++ b/string/obsolete/nsString2.h @@ -870,11 +870,11 @@ public: private: // NOT TO BE IMPLEMENTED // these signatures help clients not accidentally call the wrong thing helped by C++ automatic integral promotion - void AssignWithConversion( PRUnichar ) { } - void AssignWithConversion( const PRUnichar*, PRInt32=-1 ) { } - void AppendWithConversion( PRUnichar ) { } - void AppendWithConversion( const PRUnichar*, PRInt32=-1 ) { } - void InsertWithConversion( const PRUnichar*, PRUint32, PRInt32=-1 ) { } + void AssignWithConversion( PRUnichar ); + void AssignWithConversion( const PRUnichar*, PRInt32=-1 ); + void AppendWithConversion( PRUnichar ); + void AppendWithConversion( const PRUnichar*, PRInt32=-1 ); + void InsertWithConversion( const PRUnichar*, PRUint32, PRInt32=-1 ); }; #if 0//def NEW_STRING_APIS diff --git a/xpcom/ds/nsString.h b/xpcom/ds/nsString.h index 03fb430869bc..b9bd339ef1e0 100644 --- a/xpcom/ds/nsString.h +++ b/xpcom/ds/nsString.h @@ -425,8 +425,8 @@ public: * @param aString: string to be added to this * @return this */ - nsCString& operator=(PRUnichar aChar) {return Assign(aChar);} - nsCString& operator=(char aChar) {AssignWithConversion(aChar); return *this;} + nsCString& operator=(PRUnichar aChar) {AssignWithConversion(aChar); return *this;} + nsCString& operator=(char aChar) {return Assign(aChar);} nsCString& operator=(const PRUnichar* aString) {AssignWithConversion(aString); return *this;} nsCString& operator=(const nsCString& aString) {return Assign(aString);} @@ -775,10 +775,10 @@ public: private: // NOT TO BE IMPLEMENTED // these signatures help clients not accidentally call the wrong thing helped by C++ automatic integral promotion - void AssignWithConversion( char ) { } - void AssignWithConversion( const char*, PRInt32=-1 ) { } - void AppendWithConversion( char ) { } - void InsertWithConversion( char, PRUint32 ) { } + void AssignWithConversion( char ); + void AssignWithConversion( const char*, PRInt32=-1 ); + void AppendWithConversion( char ); + void InsertWithConversion( char, PRUint32 ); }; #if 0//def NEW_STRING_APIS diff --git a/xpcom/ds/nsString2.h b/xpcom/ds/nsString2.h index 4e0d313fa8af..bafcb690f3e1 100644 --- a/xpcom/ds/nsString2.h +++ b/xpcom/ds/nsString2.h @@ -870,11 +870,11 @@ public: private: // NOT TO BE IMPLEMENTED // these signatures help clients not accidentally call the wrong thing helped by C++ automatic integral promotion - void AssignWithConversion( PRUnichar ) { } - void AssignWithConversion( const PRUnichar*, PRInt32=-1 ) { } - void AppendWithConversion( PRUnichar ) { } - void AppendWithConversion( const PRUnichar*, PRInt32=-1 ) { } - void InsertWithConversion( const PRUnichar*, PRUint32, PRInt32=-1 ) { } + void AssignWithConversion( PRUnichar ); + void AssignWithConversion( const PRUnichar*, PRInt32=-1 ); + void AppendWithConversion( PRUnichar ); + void AppendWithConversion( const PRUnichar*, PRInt32=-1 ); + void InsertWithConversion( const PRUnichar*, PRUint32, PRInt32=-1 ); }; #if 0//def NEW_STRING_APIS diff --git a/xpcom/string/obsolete/nsString.h b/xpcom/string/obsolete/nsString.h index 03fb430869bc..b9bd339ef1e0 100644 --- a/xpcom/string/obsolete/nsString.h +++ b/xpcom/string/obsolete/nsString.h @@ -425,8 +425,8 @@ public: * @param aString: string to be added to this * @return this */ - nsCString& operator=(PRUnichar aChar) {return Assign(aChar);} - nsCString& operator=(char aChar) {AssignWithConversion(aChar); return *this;} + nsCString& operator=(PRUnichar aChar) {AssignWithConversion(aChar); return *this;} + nsCString& operator=(char aChar) {return Assign(aChar);} nsCString& operator=(const PRUnichar* aString) {AssignWithConversion(aString); return *this;} nsCString& operator=(const nsCString& aString) {return Assign(aString);} @@ -775,10 +775,10 @@ public: private: // NOT TO BE IMPLEMENTED // these signatures help clients not accidentally call the wrong thing helped by C++ automatic integral promotion - void AssignWithConversion( char ) { } - void AssignWithConversion( const char*, PRInt32=-1 ) { } - void AppendWithConversion( char ) { } - void InsertWithConversion( char, PRUint32 ) { } + void AssignWithConversion( char ); + void AssignWithConversion( const char*, PRInt32=-1 ); + void AppendWithConversion( char ); + void InsertWithConversion( char, PRUint32 ); }; #if 0//def NEW_STRING_APIS diff --git a/xpcom/string/obsolete/nsString2.h b/xpcom/string/obsolete/nsString2.h index 4e0d313fa8af..bafcb690f3e1 100644 --- a/xpcom/string/obsolete/nsString2.h +++ b/xpcom/string/obsolete/nsString2.h @@ -870,11 +870,11 @@ public: private: // NOT TO BE IMPLEMENTED // these signatures help clients not accidentally call the wrong thing helped by C++ automatic integral promotion - void AssignWithConversion( PRUnichar ) { } - void AssignWithConversion( const PRUnichar*, PRInt32=-1 ) { } - void AppendWithConversion( PRUnichar ) { } - void AppendWithConversion( const PRUnichar*, PRInt32=-1 ) { } - void InsertWithConversion( const PRUnichar*, PRUint32, PRInt32=-1 ) { } + void AssignWithConversion( PRUnichar ); + void AssignWithConversion( const PRUnichar*, PRInt32=-1 ); + void AppendWithConversion( PRUnichar ); + void AppendWithConversion( const PRUnichar*, PRInt32=-1 ); + void InsertWithConversion( const PRUnichar*, PRUint32, PRInt32=-1 ); }; #if 0//def NEW_STRING_APIS