From 3cd31353c3a1f94b31fa1042a1d9391824fae95c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A3o=20Gottwald?= Date: Thu, 13 Jun 2013 19:18:53 +0200 Subject: [PATCH] Bug 882188 - Popup notifications in background windows should only ask for attention if they'll open automatically upon gaining focus. r=gavin --- toolkit/modules/PopupNotifications.jsm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/toolkit/modules/PopupNotifications.jsm b/toolkit/modules/PopupNotifications.jsm index 8264c46c479b..a417accc9d59 100644 --- a/toolkit/modules/PopupNotifications.jsm +++ b/toolkit/modules/PopupNotifications.jsm @@ -264,7 +264,8 @@ PopupNotifications.prototype = { // tell the user that there's a notification waiting in that window. // At some point we might want to do something about background tabs here // too. - if (browser == this.tabbrowser.selectedBrowser) + if (!notification.dismissed && + browser == this.tabbrowser.selectedBrowser) this.window.getAttention(); // Notify observers that we're not showing the popup (useful for testing)