Bug 1549011 - Ignore cookie name-value-pair strings with an empty name; r=baku

Differential Revision: https://phabricator.services.mozilla.com/D29929

--HG--
extra : moz-landing-system : lando

netwerk/cookie/nsCookieService.cpp

@@ -3835,6 +3835,9 @@ bool nsCookieService::ParseAttributes(nsDependentCString& aCookieHeader,
   if (equalsFound) {
     aCookieAttributes.name = tokenString;
     aCookieAttributes.value = tokenValue;
+    if (aCookieAttributes.name.IsEmpty()) {
+      aDiscard = true;
+    }
   } else {
     aDiscard = true;
   }

netwerk/test/TestCookie.cpp

@@ -638,7 +638,7 @@ TEST(TestCookie, TestCookieMain)
   EXPECT_TRUE(CheckResult(cookie.get(), MUST_BE_NULL));
   SetACookie(cookieService, "http://parser.test/", nullptr, " =eight", nullptr);
   GetACookie(cookieService, "http://parser.test/", nullptr, cookie);
-  EXPECT_TRUE(CheckResult(cookie.get(), MUST_EQUAL, "eight"));
+  EXPECT_TRUE(CheckResult(cookie.get(), MUST_BE_NULL));
   SetACookie(cookieService, "http://parser.test/", nullptr, "test=six",
              nullptr);
   GetACookie(cookieService, "http://parser.test/", nullptr, cookie);

testing/web-platform/meta/cookies/http-state/chromium-tests.html.ini

@@ -2,9 +2,6 @@
   [chromium0006 - chromium0006]
     expected: FAIL
 
-  [chromium0012 - chromium0012]
-    expected: FAIL
-
   [chromium0007 - chromium0007]
     expected: FAIL
 

testing/web-platform/meta/cookies/http-state/general-tests.html.ini

@@ -1,7 +1,4 @@
 [general-tests.html]
-  [0021 - Ignore cookie without key in all 'Set-Cookie'.]
-    expected: FAIL
-
   [0028 - [INVALID EXPECTATION\] Ignore malformed cookies in all 'Set-Cookie' v4.]
     expected: FAIL
 

testing/web-platform/meta/cookies/http-state/mozilla-tests.html.ini

@@ -1,7 +0,0 @@
-[mozilla-tests.html]
-  [mozilla0016 - mozilla0016]
-    expected: FAIL
-
-  [mozilla0017 - mozilla0017]
-    expected: FAIL
-

testing/web-platform/meta/cookies/http-state/name-tests.html.ini

@@ -1,13 +0,0 @@
-[name-tests.html]
-  [name0025 - name0025]
-    expected: FAIL
-
-  [name0033 - name0033]
-    expected: FAIL
-
-  [name0028 - name0028]
-    expected: FAIL
-
-  [name0017 - name0017]
-    expected: FAIL
-