Backed out changeset 7f8e3d336e2f (bug 1218576)

toolkit/components/telemetry/Telemetry.cpp

@@ -2369,13 +2369,6 @@ TelemetryImpl::ClearScalars()
   return NS_OK;
 }
 
-NS_IMETHODIMP
-TelemetryImpl::FlushBatchedChildTelemetry()
-{
-  TelemetryHistogram::IPCTimerFired(nullptr, nullptr);
-  return NS_OK;
-}
-
 size_t
 TelemetryImpl::SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf)
 {

toolkit/components/telemetry/TelemetryHistogram.cpp

@@ -2625,11 +2625,8 @@ TelemetryHistogram::GetHistogramSizesofIncludingThis(mozilla::MallocSizeOf
 // It releases the lock before calling out to IPC code which can (and does)
 // Accumulate (which would deadlock)
 //
-// To ensure we don't loop IPCTimerFired->AccumulateChild->arm timer, we don't
-// unset gIPCTimerArmed until the IPC completes
-//
-// This function may be re-entered. The shared datastructures gAccumulations and
-// gKeyedAccumulations are guarded by the lock.
+// To ensure non-reentrancy, the timer is not released until the method
+// completes
 void
 TelemetryHistogram::IPCTimerFired(nsITimer* aTimer, void* aClosure)
 {

toolkit/components/telemetry/TelemetrySession.jsm

@@ -1838,7 +1838,7 @@ var Impl = {
       // content-child-shutdown is only registered for content processes.
       Services.obs.removeObserver(this, "content-child-shutdown");
       this.uninstall();
-      Telemetry.flushBatchedChildTelemetry();
+
       this.sendContentProcessPing(REASON_SAVED_SESSION);
       break;
     case TOPIC_CYCLE_COLLECTOR_BEGIN:

toolkit/components/telemetry/nsITelemetry.idl

@@ -431,10 +431,4 @@ interface nsITelemetry : nsISupports
    * Resets all the stored scalars. This is intended to be only used in tests.
    */
   void clearScalars();
-
-  /**
-   * Immediately sends any Telemetry batched on this process to the parent
-   * process. This is intended only to be used on process shutdown.
-   */
-  void flushBatchedChildTelemetry();
 };