Bug 953156 - Stop unregistering add-on chrome manifests at app shutdown; r=Unfocused

toolkit/mozapps/extensions/XPIProvider.jsm

@@ -4291,7 +4291,7 @@ var XPIProvider = {
       }
     }
     finally {
-      if (aMethod == "shutdown") {
+      if (aMethod == "shutdown" && aReason != BOOTSTRAP_REASONS.APP_SHUTDOWN) {
         LOG("Removing manifest for " + aFile.path);
         Components.manager.removeBootstrappedManifestLocation(aFile);
       }

toolkit/mozapps/extensions/test/xpcshell/test_bug953156.js

@@ -0,0 +1,51 @@
+/* Any copyright is dedicated to the Public Domain.
+ * http://creativecommons.org/publicdomain/zero/1.0/
+ */
+
+function run_test() {
+  do_test_pending();
+  createAppInfo("xpcshell@tests.mozilla.org", "XPCShell", "1", "1.9.2");
+  startupManager();
+
+  prepare_test({ }, [
+    "onNewInstall"
+  ]);
+
+  AddonManager.getInstallForFile(do_get_addon("test_bug675371"), function(install) {
+    ensure_test_completed();
+
+    do_check_neq(install, null);
+
+    prepare_test({
+      "bug675371@tests.mozilla.org": [
+        ["onInstalling", false],
+        "onInstalled"
+      ]
+    }, [
+      "onInstallStarted",
+      "onInstallEnded"
+    ], callback_soon(check_test));
+    install.install();
+  });
+}
+
+function check_test() {
+  AddonManager.getAddonByID("bug675371@tests.mozilla.org", do_exception_wrap(function(addon) {
+    do_check_neq(addon, null);
+    do_check_true(addon.isActive);
+
+    // Tests that chrome.manifest is registered when the addon is installed.
+    var target = { active: false };
+    Services.scriptloader.loadSubScript("chrome://bug675371/content/test.js", target);
+    do_check_true(target.active);
+
+    shutdownManager();
+
+    // Tests that chrome.manifest remains registered at app shutdown.
+    target.active = false;
+    Services.scriptloader.loadSubScript("chrome://bug675371/content/test.js", target);
+    do_check_true(target.active);
+
+    do_execute_soon(do_test_finished);
+  }));
+}

toolkit/mozapps/extensions/test/xpcshell/test_langpack.js

@@ -27,6 +27,11 @@ registerDirectory("XREAppDist", distroDir.parent);
 var chrome = Components.classes["@mozilla.org/chrome/chrome-registry;1"]
   .getService(Components.interfaces.nsIXULChromeRegistry);
 
+function do_unregister_manifest() {
+  let path = getFileForAddon(profileDir, "langpack-x-testing@tests.mozilla.org");
+  Components.manager.removeBootstrappedManifestLocation(path);
+}
+
 function do_check_locale_not_registered(provider) {
   let didThrow = false;
   try {
@@ -203,6 +208,7 @@ function run_test_4() {
 // Tests that a restart shuts down and restarts the add-on
 function run_test_5() {
   shutdownManager();
+  do_unregister_manifest();
   // check chrome reg that language pack is not registered
   do_check_locale_not_registered("test-langpack");
   startupManager(false);
@@ -279,6 +285,7 @@ function run_test_8() {
     do_check_false(b1.hasResource("bootstrap.js"));
 
     shutdownManager();
+    do_unregister_manifest();
     // check chrome reg that language pack is not registered
     do_check_locale_not_registered("test-langpack");
     startupManager(false);
@@ -320,6 +327,7 @@ function run_test_9() {
     do_check_false(b1.hasResource("bootstrap.js"));
 
     shutdownManager();
+    do_unregister_manifest();
     // check chrome reg that language pack is not registered
     do_check_locale_not_registered("test-langpack");
     startupManager(false);

toolkit/mozapps/extensions/test/xpcshell/xpcshell-shared.ini

@@ -140,6 +140,7 @@ fail-if = os == "android"
 [test_bug740612.js]
 [test_bug753900.js]
 [test_bug757663.js]
+[test_bug953156.js]
 [test_cacheflush.js]
 [test_checkcompatibility.js]
 [test_childprocess.js]