Bug 1516083 - Add "Search Tabs" to the all tabs menu. r=jaws

Differential Revision: https://phabricator.services.mozilla.com/D15251

--HG--
extra : moz-landing-system : lando

browser/base/content/browser-allTabsMenu.inc.xul

@@ -13,12 +13,15 @@
   <panelmultiview mainViewId="allTabsMenu-allTabsView" disablekeynav="true">
     <panelview id="allTabsMenu-allTabsView" class="PanelUI-subView">
       <vbox class="panel-subview-body">
-        <toolbarbutton id="allTabsUndoCloseButton"
-                       class="undo-close-tab subviewbutton subviewbutton-iconic"
+        <toolbarbutton id="allTabsMenu-undoCloseTab"
+                       class="subviewbutton subviewbutton-iconic"
                        label="&undoCloseTab.label;"
                        key="key_undoCloseTab"
                        command="History:UndoCloseTab"/>
-        <toolbarseparator id="allTabsMenu-containerTabsSeparator"/>
+        <toolbarbutton id="allTabsMenu-searchTabs"
+                       class="subviewbutton subviewbutton-iconic"
+                       oncommand="gTabsPanel.searchTabs();"
+                       label="&allTabsMenu.searchTabs.label;"/>
         <toolbarbutton id="allTabsMenu-containerTabsButton"
                        class="subviewbutton subviewbutton-nav"
                        closemenu="none"

browser/base/content/browser-allTabsMenu.js

@@ -47,15 +47,13 @@ var gTabsPanel = {
 
     this.allTabsView.addEventListener("ViewShowing", (e) => {
       PanelUI._ensureShortcutsShown(this.allTabsView);
-      e.target.querySelector(".undo-close-tab").disabled =
+      document.getElementById("allTabsMenu-undoCloseTab").disabled =
           SessionStore.getClosedTabCount(window) == 0;
 
       let containersEnabled = Services.prefs.getBoolPref("privacy.userContext.enabled")
                                 && !PrivateBrowsingUtils.isWindowPrivate(window);
       document.getElementById("allTabsMenu-containerTabsButton")
         .hidden = !containersEnabled;
-      document.getElementById("allTabsMenu-containerTabsSeparator")
-        .hidden = !containersEnabled;
 
       let hasHiddenTabs = gBrowser.visibleTabs.length < gBrowser.tabs.length;
       document.getElementById("allTabsMenu-hiddenTabsButton")
@@ -134,4 +132,9 @@ var gTabsPanel = {
     }, {once: true});
     this.showAllTabsPanel();
   },
+
+  searchTabs() {
+    focusAndSelectUrlBar();
+    gURLBar.typeRestrictToken(UrlbarTokenizer.RESTRICT.OPENPAGE);
+  },
 };

browser/locales/en-US/chrome/browser/browser.dtd

@@ -108,6 +108,9 @@ These items have the same accesskey but will never be visible at the same time.
 <!ENTITY  hiddenTabs.label                   "Hidden Tabs">
 
 <!ENTITY  listAllTabs.label      "List all tabs">
+<!-- LOCALIZATION NOTE (allTabsMenu.searchTabs.label): "Search" is a verb, as
+in "Search through tabs". -->
+<!ENTITY  allTabsMenu.searchTabs.label       "Search Tabs">
 
 <!ENTITY tabCmd.label "New Tab">
 <!ENTITY tabCmd.accesskey "T">

browser/themes/shared/tabs.inc.css

@@ -781,10 +781,14 @@
   list-style-image: url(chrome://browser/skin/tabbrowser/tab-audio-muted.svg);
 }
 
-.undo-close-tab {
+#allTabsMenu-undoCloseTab {
   list-style-image: url(chrome://browser/skin/undo.svg);
 }
 
-.undo-close-tab > .toolbarbutton-icon:-moz-locale-dir(rtl) {
+#allTabsMenu-undoCloseTab > .toolbarbutton-icon:-moz-locale-dir(rtl) {
   transform: scaleX(-1);
 }
+
+#allTabsMenu-searchTabs {
+  list-style-image: url(chrome://browser/skin/search-glass.svg);
+}