Bug 1552629 - Fix misaligned "Edit and Resend" button in the netmonitor Headers panel;r=Honza

If the "Referrer Policy" header is missing, summaryReferrerPolicy is null,
so summaryEditAndResendBtn contains only the "Edit and Resend" button, making it
misaligned. We fix this by making sure summaryEditAndResendBtn always contains
the last non-null header.

Differential Revision: https://phabricator.services.mozilla.com/D32322

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Vincent Lequertier 2019-05-27 07:23:44 +00:00
Родитель c016ea09a2
Коммит 3f41c3104f
1 изменённых файлов: 12 добавлений и 7 удалений

Просмотреть файл

@ -449,10 +449,20 @@ class HeadersPanel extends Component {
const summaryReferrerPolicy = referrerPolicy ?
this.renderSummary(SUMMARY_REFERRER_POLICY, referrerPolicy) : null;
const summaryItems = [
summaryUrl,
trackingProtectionStatus,
summaryMethod,
summaryAddress,
summaryStatus,
summaryVersion,
summaryReferrerPolicy,
].filter(summaryItem => summaryItem !== null);
const summaryEditAndResendBtn = (
div({
className: "summary-edit-and-resend" },
summaryReferrerPolicy,
summaryItems.pop(),
button({
className: "edit-and-resend-button devtools-button",
onClick: cloneSelectedRequest,
@ -463,12 +473,7 @@ class HeadersPanel extends Component {
return (
div({ className: "panel-container" },
div({ className: "headers-overview" },
summaryUrl,
trackingProtectionStatus,
summaryMethod,
summaryAddress,
summaryStatus,
summaryVersion,
summaryItems,
summaryEditAndResendBtn,
),
PropertiesView({