Fix a whole bunch of bookmarks bugs: #68018, #78586, #71776, #77814, #78373. r=hwaara, sr=alecf (r=doron on 68018). Brought to you by: Fabian Guisset <hidday@geocities.com>

#78997, fix offline pref panel to match the spec. Patch by Stephen Walker <walk84@usa.net>, r=hwaara, sr=sspitzer.

#79058, fix up the offline pref panel to show up correctly in the pref-tree. r=doron, sr=sspitzer.

xpfe/browser/resources/content/navigator.xul

@@ -113,6 +113,9 @@ Contributor(s): ______________________________________. -->
     <popup id="backMenu" oncreate="BrowserBackMenu(event);" oncommand="gotoHistoryIndex(event);"/>
     <popup id="forwardMenu" oncreate="BrowserForwardMenu(event);" oncommand="gotoHistoryIndex(event);"/>
     <popup id="sidebarPopup"/>
+
+    <!-- context menu for personal toolbar -->
+    <popupset id="popupset"/>
  
     <!-- context menu -->
     <popupset id="contentAreaContextSet"/>

xpfe/components/bookmarks/resources/bookmarks.xul

@@ -48,6 +48,7 @@
   <!-- The order of loading of these script files is IMPORTANT -->
 
   <!-- Shared Libraries -->
+  <script type="application/x-javascript" src="chrome://global/content/treePopups.js"/>
   <script type="application/x-javascript" src="chrome://global/content/nsTreeUtils.js"/>
   <script type="application/x-javascript" src="chrome://global/content/strres.js"/>
 
@@ -102,7 +103,7 @@
     <key id="key_cut"/>
     <key id="key_copy"/>
     <key id="key_paste"/>
-    <key id="key_delete"/>
+    <key id="key_bm_delete" keycode="VK_DELETE" observes="cmd_bm_delete"/>
     <key id="key_selectAll"/>
     <key id="bm_key_find"  
          key="&edit.find.keybinding;"  
@@ -235,7 +236,7 @@
       <button class="button-toolbar" id="rename" label="&command.rename.label;"
               observes="cmd_rename"/>
       <button class="button-toolbar" id="delete" label="&command.delete.label;"
-              observes="cmd_delete"/>
+              observes="cmd_bm_delete"/>
     </toolbar>
   </toolbox>
   

xpfe/components/bookmarks/resources/bookmarksPanel.xul

@@ -61,7 +61,7 @@
   <popupset id="popupset"/>
   
   <!-- bookmarks string bundle -->
-  <stringbundleset id="bookmarksStringBundles"/>
+  <stringbundleset id="stringbundleset"/>
   
   <!-- bookmarks & edit commands -->
   <commandset id="bookmarksItems"/>

xpfe/components/bookmarks/resources/bookmarksTree.js

@@ -367,7 +367,9 @@ BookmarksTree.prototype = {
   {
     var selectedItem = this.getBestItem();
     if (!selectedItem) return "NC:BookmarksRoot";
-    while (selectedItem) {
+    // If we don't check for localName we walk the DOM tree up to the window node,
+    // which is Bad.
+    while (selectedItem.localName == "treeitem") {
       if (selectedItem.getAttribute("container") == "true")
         return NODE_ID(selectedItem);
       selectedItem = selectedItem.parentNode.parentNode;

xpfe/components/prefwindow/resources/content/pref-offline.xul

@@ -54,8 +54,6 @@
     </radiogroup> 
 </titledbox>
 
-<separator/>
-
 <titledbox orient="vertical">
     <label value="&header2;"/>
     <radiogroup id="whengoingOnlinestate" orient="vertical" autostretch="never"
@@ -67,8 +65,6 @@
     </radiogroup>
 </titledbox>
 
-<separator/>
-
 <titledbox orient="vertical">
     <label value="&header3;"/>
 

xpfe/components/prefwindow/resources/content/preftree.xul

@@ -139,12 +139,6 @@
       </treechildren>
     </treeitem>
 
-    <treeitem container="true" open="true" id="offlineItem">
-      <treerow>
-        <treecell class="treecell-indent" url="chrome://communicator/content/pref/pref-offline.xul" label="&offline.label;"/> 
-      </treerow>
-    </treeitem>
-
     <treeitem container="true" open="true" id="debugItem">
       <treerow>       
         <treecell class="treecell-indent" url="chrome://communicator/content/pref/pref-debug.xul" label="&debug.label;"/> 
@@ -165,6 +159,13 @@
         
       </treechildren>
     </treeitem>
+
+    <treeitem container="false" id="offlineItem">
+      <treerow>
+        <treecell class="treecell-indent" url="chrome://communicator/content/pref/pref-offline.xul" label="&offline.label;"/> 
+      </treerow>
+    </treeitem>
+
   </treechildren>
 
 </tree>

xpfe/components/prefwindow/resources/locale/en-US/pref-offline.dtd

@@ -4,8 +4,8 @@
 <!ENTITY window.title  "Offline">
 <!ENTITY boxHeader  "Offline">
 <!ENTITY rHeader  "Startup Mode">
-<!ENTITY descipt1 "Mozilla can start in either online or offline modes. When online you have full 
-access to your network.  When offline you can only read messages that you have previously downloaded to your local computer">
+<!ENTITY descipt1 "Mozilla can start in either online or offline mode. When online you have full 
+access to your network.  When offline you can only read messages that you have previously downloaded to your local computer.">
 <!ENTITY prevRadio  "Remember my previous mode">
 <!ENTITY communRemember "Mozilla will remember the state it was in last and start in that mode.">
 <!ENTITY askOfflineRadio  "Ask me at startup">