Bug 1789458 - Backout asserts from 1788290. r=keeler

Differential Revision: https://phabricator.services.mozilla.com/D156944

security/manager/ssl/nsNSSIOLayer.cpp

@@ -1204,26 +1204,24 @@ static void reportHandshakeResult(int32_t bytesTransferred, bool wasReading,
 
   if (bucket == 0) {
     // Web Privacy Telemetry for successful connections.
-    // Discard errors from these function calls in release.
     bool success = true;
 
     bool usedPrivateDNS = false;
     success &= socketInfo->GetUsedPrivateDNS(&usedPrivateDNS) == NS_OK;
-    MOZ_ASSERT(success, "Transport Security Getters should not fail.");
 
     bool madeOCSPRequest = false;
     success &= socketInfo->GetMadeOCSPRequests(&madeOCSPRequest) == NS_OK;
-    MOZ_ASSERT(success, "Transport Security Getters should not fail.");
 
     uint16_t protocolVersion = 0;
     success &= socketInfo->GetProtocolVersion(&protocolVersion) == NS_OK;
-    MOZ_ASSERT(success, "Transport Security Getters should not fail.");
     bool usedTLS13 = protocolVersion == 4;
 
     bool usedECH = false;
     success &= socketInfo->GetIsAcceptedEch(&usedECH) == NS_OK;
-    MOZ_ASSERT(success, "Transport Security Getters should not fail.");
 
+    // As bucket is 0 we are reporting the results of a sucessful connection
+    // and so TransportSecurityInfo should be populated. However, this isn't
+    // happening in all cases, see Bug 1789458.
     if (success) {
       uint8_t TLSPrivacyResult = 0;
       TLSPrivacyResult |= usedTLS13 << 0;