From 411230f211f91b09553ff936a1fa12b638c225d1 Mon Sep 17 00:00:00 2001
From: Mike Conley <mconley@mozilla.com>
Date: Thu, 23 Mar 2017 00:05:03 -0400
Subject: [PATCH] Bug 1339775 - Add role="checkbox" for specially styled
 in-content checkboxes. r=jaws

MozReview-Commit-ID: IZhRECggz4j

--HG--
extra : rebase_source : a95bafc0996c6021a4dff4f0cd7addb1a45a9f6e
---
 browser/base/content/aboutNetError.xhtml                  | 2 +-
 browser/base/content/aboutTabCrashed.xhtml                | 8 ++++----
 .../client/aboutdebugging/components/addons/controls.js   | 1 +
 .../aboutperformance/content/aboutPerformance.xhtml       | 4 ++--
 toolkit/content/aboutNetworking.xhtml                     | 4 ++--
 5 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/browser/base/content/aboutNetError.xhtml b/browser/base/content/aboutNetError.xhtml
index 6acf6a4b97b5..a60abe57516d 100644
--- a/browser/base/content/aboutNetError.xhtml
+++ b/browser/base/content/aboutNetError.xhtml
@@ -630,7 +630,7 @@
            init for other error types .-->
       <div id="certificateErrorReporting">
         <p class="toggle-container-with-text">
-          <input type="checkbox" id="automaticallyReportInFuture" />
+          <input type="checkbox" id="automaticallyReportInFuture" role="checkbox" />
           <label for="automaticallyReportInFuture" id="automaticallyReportInFuture">&errorReporting.automatic2;</label>
         </p>
       </div>
diff --git a/browser/base/content/aboutTabCrashed.xhtml b/browser/base/content/aboutTabCrashed.xhtml
index dd3b5ca770f4..185abb0004af 100644
--- a/browser/base/content/aboutTabCrashed.xhtml
+++ b/browser/base/content/aboutTabCrashed.xhtml
@@ -49,7 +49,7 @@
         <h2>&tabCrashed.requestReport;</h2>
 
         <div class="checkbox-with-label">
-          <input type="checkbox" id="sendReport"/>
+          <input type="checkbox" id="sendReport" role="checkbox"/>
           <label for="sendReport">&tabCrashed.sendReport2;</label>
         </div>
 
@@ -59,13 +59,13 @@
           </li>
 
           <li class="checkbox-with-label">
-            <input type="checkbox" id="includeURL"/>
+            <input type="checkbox" id="includeURL" role="checkbox"/>
             <label for="includeURL">&tabCrashed.includeURL2;</label>
           </li>
 
           <li id="requestEmail" hidden="true">
             <div class="checkbox-with-label">
-              <input type="checkbox" id="emailMe"/>
+              <input type="checkbox" id="emailMe" role="checkbox"/>
               <label for="emailMe">&tabCrashed.emailMe;</label>
             </div>
             <input type="text" id="email" placeholder="&tabCrashed.emailPlaceholder;"/>
@@ -75,7 +75,7 @@
         <div id="requestAutoSubmit" hidden="true">
           <h2>&tabCrashed.requestAutoSubmit2;</h2>
           <div class="checkbox-with-label">
-            <input type="checkbox" id="autoSubmit"/>
+            <input type="checkbox" id="autoSubmit" role="checkbox"/>
             <label for="autoSubmit">&tabCrashed.autoSubmit2;</label>
           </div>
         </div>
diff --git a/devtools/client/aboutdebugging/components/addons/controls.js b/devtools/client/aboutdebugging/components/addons/controls.js
index aabcbf8802e1..d5d67bc47956 100644
--- a/devtools/client/aboutdebugging/components/addons/controls.js
+++ b/devtools/client/aboutdebugging/components/addons/controls.js
@@ -77,6 +77,7 @@ module.exports = createClass({
             type: "checkbox",
             checked: !debugDisabled,
             onChange: this.onEnableAddonDebuggingChange,
+            role: "checkbox",
           }),
           dom.label({
             className: "addons-debugging-label",
diff --git a/toolkit/components/aboutperformance/content/aboutPerformance.xhtml b/toolkit/components/aboutperformance/content/aboutPerformance.xhtml
index d0c387b35377..97e496237c2f 100644
--- a/toolkit/components/aboutperformance/content/aboutPerformance.xhtml
+++ b/toolkit/components/aboutperformance/content/aboutPerformance.xhtml
@@ -166,11 +166,11 @@
     </div>
     <div class="options">
       <div class="toggle-container-with-text">
-        <input type="checkbox" checked="false" id="check-display-recent"></input>
+        <input type="checkbox" checked="false" id="check-display-recent" role="checkbox"></input>
         <label for="check-display-recent" id="label-display-recent">Display only the last few seconds.</label>
       </div>
       <div class="toggle-container-with-text">
-        <input type="checkbox" checked="true" id="check-autorefresh"></input>
+        <input type="checkbox" checked="true" id="check-autorefresh" role="checkbox"></input>
         <label for="check-autorefresh">Refresh automatically</label>
       </div>
     </div>
diff --git a/toolkit/content/aboutNetworking.xhtml b/toolkit/content/aboutNetworking.xhtml
index ca53ca928526..d2c65914d90b 100644
--- a/toolkit/content/aboutNetworking.xhtml
+++ b/toolkit/content/aboutNetworking.xhtml
@@ -22,7 +22,7 @@
             <div class="container">
                 <h1 class="title">&aboutNetworking.warning;</h1>
                 <div class="toggle-container-with-text">
-                    <input id="warncheck" type="checkbox" checked="yes" />
+                    <input id="warncheck" type="checkbox" checked="yes" role="checkbox" />
                     <label for="warncheck">&aboutNetworking.showNextTime;</label>
                 </div>
                 <div>
@@ -58,7 +58,7 @@
                 </div>
                 <div id="refreshDiv" class="toggle-container-with-text">
                     <button id="refreshButton">&aboutNetworking.refresh;</button>
-                    <input id="autorefcheck" type="checkbox" name="Autorefresh" />
+                    <input id="autorefcheck" type="checkbox" name="Autorefresh" role="checkbox" />
                     <label for="autorefcheck">&aboutNetworking.autoRefresh;</label>
                 </div>
             </div>