Backed out changeset 079a3bda7172 (bug 1649613) for causing bug 1554453.

toolkit/modules/Sqlite.jsm

@@ -19,6 +19,7 @@ const { setTimeout } = ChromeUtils.import("resource://gre/modules/Timer.jsm");
 XPCOMUtils.defineLazyModuleGetters(this, {
   AsyncShutdown: "resource://gre/modules/AsyncShutdown.jsm",
   Services: "resource://gre/modules/Services.jsm",
+  OS: "resource://gre/modules/osfile.jsm",
   Log: "resource://gre/modules/Log.jsm",
   FileUtils: "resource://gre/modules/FileUtils.jsm",
   PromiseUtils: "resource://gre/modules/PromiseUtils.jsm",
@@ -1033,16 +1034,7 @@ function openConnection(options) {
   }
 
   // Retains absolute paths and normalizes relative as relative to profile.
-  let path = options.path;
-  if (
-    !path.includes(Services.dirsvc.get("ProfD", Ci.nsIFile).path) &&
-    !path.includes(Services.dirsvc.get("CurWorkD", Ci.nsIFile).path)
-  ) {
-    path = PathUtils.joinRelative(
-      Services.dirsvc.get("ProfD", Ci.nsIFile).path,
-      options.path
-    );
-  }
+  let path = OS.Path.join(OS.Constants.Path.profileDir, options.path);
 
   let sharedMemoryCache =
     "sharedMemoryCache" in options ? options.sharedMemoryCache : true;
@@ -1074,7 +1066,7 @@ function openConnection(options) {
   }
 
   let file = FileUtils.File(path);
-  let identifier = getIdentifierByFileName(PathUtils.filename(path));
+  let identifier = getIdentifierByFileName(OS.Path.basename(path));
 
   log.info("Opening database: " + path + " (" + identifier + ")");
 
@@ -1189,7 +1181,7 @@ function cloneStorageConnection(options) {
   }
 
   let path = source.databaseFile.path;
-  let identifier = getIdentifierByFileName(PathUtils.filename(path));
+  let identifier = getIdentifierByFileName(OS.Path.basename(path));
 
   log.info("Cloning database: " + path + " (" + identifier + ")");