Bug 1061053 - Fix more bad implicit constructors in storage; r=mak

--HG--
extra : rebase_source : a18eaa1cf7968fb5b8c8923d85bd99d77c427e6e

storage/test/test_StatementCache.cpp

@@ -6,6 +6,7 @@
 
 #include "storage_test_harness.h"
 
+#include "mozilla/Attributes.h"
 #include "mozilla/storage/StatementCache.h"
 using namespace mozilla::storage;
 
@@ -19,7 +20,7 @@ using namespace mozilla::storage;
 class SyncCache : public StatementCache<mozIStorageStatement>
 {
 public:
-  SyncCache(nsCOMPtr<mozIStorageConnection>& aConnection)
+  explicit SyncCache(nsCOMPtr<mozIStorageConnection>& aConnection)
   : StatementCache<mozIStorageStatement>(aConnection)
   {
   }
@@ -28,7 +29,7 @@ public:
 class AsyncCache : public StatementCache<mozIStorageAsyncStatement>
 {
 public:
-  AsyncCache(nsCOMPtr<mozIStorageConnection>& aConnection)
+  explicit AsyncCache(nsCOMPtr<mozIStorageConnection>& aConnection)
   : StatementCache<mozIStorageAsyncStatement>(aConnection)
   {
   }
@@ -41,7 +42,7 @@ public:
 class StringWrapper : public nsCString
 {
 public:
-  StringWrapper(const char* aOther)
+  MOZ_IMPLICIT StringWrapper(const char* aOther)
   {
     this->Assign(aOther);
   }

storage/test/test_async_callbacks_with_spun_event_loops.cpp

@@ -41,7 +41,7 @@ public:
   // Whether an error was received.
   static bool sError;
 
-  UnownedCallback(mozIStorageConnection* aDBConn)
+  explicit UnownedCallback(mozIStorageConnection* aDBConn)
   : mDBConn(aDBConn)
   , mCompleted(false)
   {

storage/test/test_true_async.cpp

@@ -107,7 +107,7 @@ void watch_for_mutex_use_on_this_thread()
 class ThreadWedger : public nsRunnable
 {
 public:
-  ThreadWedger(nsIEventTarget *aTarget)
+  explicit ThreadWedger(nsIEventTarget *aTarget)
   : mReentrantMonitor("thread wedger")
   , unwedged(false)
   {

storage/test/test_unlock_notify.cpp

@@ -28,7 +28,7 @@ enum State {
 class DatabaseLocker : public nsRunnable
 {
 public:
-  DatabaseLocker(const char* aSQL)
+  explicit DatabaseLocker(const char* aSQL)
   : monitor("DatabaseLocker::monitor")
   , mSQL(aSQL)
   , mState(STARTING)