Bug 1590354 - Remove checks for remote minidumps directory; r=jmaher

Whereas:
 - desktop tests don't make this check;
 - the check for directory existence has been troublesome and almost never useful;
 - bug classification of this condition has been troublesome;
 - if a startup crash actually did occur before crashreporter init, there would still be an indication in logcat and possibly a tombstone, and the "No test summary found" check would definitely be triggered;
Let's stop checking for minidumps directory creation.

Differential Revision: https://phabricator.services.mozilla.com/D54755

--HG--
extra : moz-landing-system : lando

build/mobile/remoteautomation.py

@@ -155,13 +155,7 @@ class RemoteAutomation(Automation):
             dumpDir = tempfile.mkdtemp()
             remoteCrashDir = posixpath.join(self.remoteProfile, 'minidumps')
             if not self.device.is_dir(remoteCrashDir):
-                # If crash reporting is enabled (MOZ_CRASHREPORTER=1), the
-                # minidumps directory is automatically created when Fennec
-                # (first) starts, so its lack of presence is a hint that
-                # something went wrong.
-                print("Automation Error: No crash directory (%s) found on remote device" %
-                      remoteCrashDir)
-                return True
+                return False
             self.device.pull(remoteCrashDir, dumpDir)
 
             logger = get_default_logger()

testing/gtest/remotegtests.py

@@ -186,8 +186,7 @@ class RemoteGTests(object):
             dump_dir = tempfile.mkdtemp()
             remote_dir = self.remote_minidumps
             if not self.device.is_dir(remote_dir):
-                log.warning("No crash directory (%s) found on remote device" % remote_dir)
-                return True
+                return False
             self.device.pull(remote_dir, dump_dir)
             crashed = mozcrash.check_for_crashes(dump_dir, symbols_path, test_name="gtest")
         except Exception as e:

testing/mochitest/runjunit.py

@@ -314,13 +314,7 @@ class JUnitTestRunner(MochitestDesktop):
             dump_dir = tempfile.mkdtemp()
             remote_dir = posixpath.join(self.remote_profile, 'minidumps')
             if not self.device.is_dir(remote_dir):
-                # If crash reporting is enabled (MOZ_CRASHREPORTER=1), the
-                # minidumps directory is automatically created when the app
-                # (first) starts, so its lack of presence is a hint that
-                # something went wrong.
-                print("Automation Error: " +
-                      "No crash directory ({}) found on remote device".format(remote_dir))
-                return True
+                return False
             self.device.pull(remote_dir, dump_dir)
             crashed = mozcrash.log_crashes(self.log, dump_dir, symbols_path,
                                            test=self.current_full_name)

testing/mozbase/mozrunner/mozrunner/devices/base.py

@@ -59,10 +59,6 @@ class Device(object):
         """
         remote_dump_dir = posixpath.join(self.app_ctx.remote_profile, 'minidumps')
         local_dump_dir = tempfile.mkdtemp()
-        if not self.device.is_dir(remote_dump_dir):
-            # This may be a hint that something went wrong during browser
-            # start-up if (MOZ_CRASHREPORTER=1)
-            print("WARNING: No crash directory {} found on remote device".format(remote_dump_dir))
         try:
             self.device.pull(remote_dump_dir, local_dump_dir)
         except ADBError as e:

testing/raptor/raptor/raptor.py

@@ -1688,7 +1688,6 @@ class RaptorAndroid(PerftestAndroid, Raptor):
             dump_dir = tempfile.mkdtemp()
             remote_dir = posixpath.join(self.remote_profile, 'minidumps')
             if not self.device.is_dir(remote_dir):
-                LOG.error("No crash directory (%s) found on remote device" % remote_dir)
                 return
             self.device.pull(remote_dir, dump_dir)
             mozcrash.log_crashes(LOG, dump_dir, self.config['symbols_path'])