Bug 1398057 - Not all command arguments are printed to the log. r=jgraham

By logging the used browser arguments from geckodriver only the
-marionette argument ends up in the log. Instead mozrunner should
be used which knows about any of them.

MozReview-Commit-ID: J9px0pWSwQm

--HG--
extra : rebase_source : 36730f7c2ecffa7a28dda3d16404f523bd075d35

testing/geckodriver/CHANGES.md

@@ -17,6 +17,8 @@ Unreleased
 
 ### Changed
 
+- Log all used application arguments and not only `-marionette`
+
 - Early abort connection attempts to Marionette if the Firefox process
   closed unexpectetly
 
@@ -41,7 +43,7 @@ Unreleased
 
 - [webdriver crate] upgraded to version 0.30.0
 
-- [mozrunner crate] upgraded to version 0.4.2
+- [mozrunner crate] upgraded to version 0.5.0
 
 
 0.18.0 (2017-07-10)

testing/geckodriver/Cargo.toml

@@ -4,6 +4,7 @@ version = "0.18.0"
 authors = [
   "James Graham <james@hoppipolla.co.uk>",
   "Andreas Tolfsen <ato@sny.no>",
+  "Henrik Skupin <mail@hskupin.info"
 ]
 description = "Proxy for using WebDriver clients to interact with Gecko-based browsers."
 keywords = ["webdriver", "w3c", "httpd", "mozilla", "firefox"]

testing/geckodriver/src/logging.rs

@@ -130,7 +130,8 @@ impl Format for GeckoFormat {
         // TODO(ato): Quite sure this is the wrong way to filter records with slog,
         // but I do not comprehend how slog works.
         let module = record.module();
-        if module.starts_with("geckodriver") || module.starts_with("webdriver") {
+        if module.starts_with("geckodriver") || module.starts_with("webdriver") ||
+           module.starts_with("mozrunner") {
             let ts = format_ts(Local::now());
             let level = record.level().to_gecko();
             let _ = try!(write!(io, "{}\t{}\t{}\t{}\n", ts, module, level, record.msg()));

testing/geckodriver/src/marionette.rs

@@ -466,7 +466,6 @@ impl MarionetteHandler {
                                     format!("Failed to set preferences: {}", e))
             }));
 
-        info!("Starting browser {} with args {:?}", binary.display(), runner.args());
         try!(runner.start()
             .map_err(|e| {
                 WebDriverError::new(ErrorStatus::SessionNotCreated,