Bug 1703914 - Removed --toolbarbutton-icon-fill-opacity CSS var r=mconley,desktop-theme-reviewers,dao

All uses of --toolbarbutton-icon-fill-opacity have been removed.

Differential Revision: https://phabricator.services.mozilla.com/D120352

browser/themes/linux/browser.css

@@ -21,7 +21,6 @@
 
   --toolbarbutton-border-radius: 4px;
   --toolbarbutton-vertical-text-padding: calc(var(--toolbarbutton-inner-padding) - 1px);
-  --toolbarbutton-icon-fill-opacity: 1;
 
   --panel-separator-color: ThreeDShadow;
 

browser/themes/osx/browser.css

@@ -14,7 +14,6 @@
 
   --toolbarbutton-vertical-text-padding: calc(var(--toolbarbutton-inner-padding) + 1px);
   --toolbarbutton-border-radius: 4px;
-  --toolbarbutton-icon-fill-opacity: 1;
 
   --panel-separator-color: hsla(210,4%,10%,.14);
 

browser/themes/shared/customizableui/panelUI.inc.css

@@ -216,7 +216,6 @@ toolbarseparator + .panel-subview-body,
   list-style-image: url(chrome://global/skin/icons/info.svg);
   -moz-context-properties: fill, fill-opacity;
   fill: currentColor;
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
   padding: 4px;
 }
 

browser/themes/shared/notification-icons.inc.css

@@ -24,7 +24,6 @@
 .permission-popup-permission-icon {
   -moz-context-properties: fill, fill-opacity;
   fill: currentColor;
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
 }
 
 .blocked-permission-icon:-moz-focusring,

browser/themes/shared/tabs.inc.css

@@ -446,7 +446,6 @@
 
 .tab-close-button {
   -moz-context-properties: fill, fill-opacity;
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
   margin-inline-end: calc(var(--inline-tab-padding) / -2);
   width: 24px;
   height: 24px;
@@ -683,7 +682,6 @@
 #tabbrowser-arrowscrollbox::part(scrollbutton-up),
 #tabbrowser-arrowscrollbox::part(scrollbutton-down) {
   fill: var(--toolbarbutton-icon-fill);
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
 }
 
 /* New tab button */
@@ -707,7 +705,6 @@
   display: block;
   -moz-context-properties: fill, fill-opacity, stroke;
   fill: currentColor;
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
   stroke: transparent;
   /* "!important" is necessary to override the rule in toolbarbutton.css */
   margin: -7px 0 0 !important;

browser/themes/shared/toolbarbutton-icons.inc.css

@@ -7,7 +7,6 @@
 }
 
 :root:-moz-lwtheme {
-  --toolbarbutton-icon-fill-opacity: 1;
   --toolbarbutton-icon-fill-attention: var(--lwt-toolbarbutton-icon-fill-attention, rgb(0,97,224));
 }
 
@@ -21,7 +20,6 @@ toolbar[brighttext]:-moz-lwtheme {
   color: inherit !important;
   -moz-context-properties: fill, fill-opacity;
   fill: var(--toolbarbutton-icon-fill);
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
 }
 
 .toolbarbutton-animatable-box {
@@ -420,7 +418,6 @@ toolbar[brighttext] #panic-button[open] {
 #save-to-pocket-button {
   list-style-image: url("chrome://browser/skin/pocket-outline.svg");
   fill: var(--toolbarbutton-icon-fill);
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
 }
 
 #save-to-pocket-button[open="true"],
@@ -440,7 +437,6 @@ toolbar[brighttext] #panic-button[open] {
 toolbarbutton.bookmark-item {
   -moz-context-properties: fill, fill-opacity;
   fill: var(--toolbarbutton-icon-fill);
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
 }
 
 .bookmark-item[container] {

browser/themes/shared/urlbar-searchbar.inc.css

@@ -176,7 +176,6 @@
   background-position: center;
   -moz-context-properties: fill, fill-opacity;
   fill: var(--toolbarbutton-icon-fill);
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
 }
 
 #urlbar.searchButton > #urlbar-input-container[pageproxystate="invalid"] > #urlbar-search-button {

browser/themes/windows/browser-aero.css

@@ -73,7 +73,6 @@
           }
           :root[tabsintitlebar][lwt-default-theme-in-dark-mode] #titlebar {
             --toolbarbutton-icon-fill: currentColor;
-            --toolbarbutton-icon-fill-opacity: .7;
           }
         }
         } /*** end !proton ***/
@@ -327,11 +326,6 @@
 }
 
 @media (-moz-windows-glass) {
-  /* Set to full fill-opacity to improve visibility of toolbar buttons on aero glass. */
-  #TabsToolbar:not(:-moz-lwtheme) {
-    --toolbarbutton-icon-fill-opacity: 1;
-  }
-
   #toolbar-menubar:not(:-moz-lwtheme) {
     text-shadow: 0 0 .5em white, 0 0 .5em white, 0 1px 0 rgba(255,255,255,.4);
   }

browser/themes/windows/browser.css

@@ -16,7 +16,6 @@
 
   --toolbarbutton-vertical-text-padding: calc(var(--toolbarbutton-inner-padding) - 1px);
   --toolbarbutton-border-radius: 4px;
-  --toolbarbutton-icon-fill-opacity: 1;
 
   --panel-separator-color: ThreeDLightShadow;
 

toolkit/components/printing/content/printPagination.css

@@ -69,7 +69,6 @@
   background-size: 12px;
   -moz-context-properties: fill, fill-opacity;
   fill: var(--toolbarbutton-icon-fill);
-  fill-opacity: var(--toolbarbutton-icon-fill-opacity);
 }
 
 .toolbarButton:hover {