Bug 1050611 - Fix more bad implicit constructors in dom and docshell; r=smaug

content/base/public/nsReferencedElement.h

@@ -116,7 +116,7 @@ private:
     virtual void Clear() { mTarget = nullptr; }
     virtual ~Notification() {}
   protected:
-    Notification(nsReferencedElement* aTarget)
+    explicit Notification(nsReferencedElement* aTarget)
       : mTarget(aTarget)
     {
       NS_PRECONDITION(aTarget, "Must have a target");

content/svg/content/src/SVGAnimationElement.h

@@ -27,7 +27,7 @@ class SVGAnimationElement : public SVGAnimationElementBase,
                             public SVGTests
 {
 protected:
-  SVGAnimationElement(already_AddRefed<mozilla::dom::NodeInfo>& aNodeInfo);
+  explicit SVGAnimationElement(already_AddRefed<mozilla::dom::NodeInfo>& aNodeInfo);
   nsresult Init();
   virtual ~SVGAnimationElement();
 
@@ -94,7 +94,7 @@ public:
 
   class TargetReference : public nsReferencedElement {
   public:
-    TargetReference(SVGAnimationElement* aAnimationElement) :
+    explicit TargetReference(SVGAnimationElement* aAnimationElement) :
       mAnimationElement(aAnimationElement) {}
   protected:
     // We need to be notified when target changes, in order to request a

content/svg/content/src/nsSVGElement.h

@@ -73,7 +73,7 @@ class nsSVGElement : public nsSVGElementBase    // nsIContent
                    , public nsIDOMSVGElement
 {
 protected:
-  nsSVGElement(already_AddRefed<mozilla::dom::NodeInfo>& aNodeInfo);
+  explicit nsSVGElement(already_AddRefed<mozilla::dom::NodeInfo>& aNodeInfo);
   friend nsresult NS_NewSVGElement(mozilla::dom::Element **aResult,
                                    already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo);
   nsresult Init();

docshell/base/LoadContext.h

@@ -92,7 +92,7 @@ public:
   {}
 
   // Constructor taking reserved appId for the safebrowsing cookie.
-  LoadContext(uint32_t aAppId)
+  explicit LoadContext(uint32_t aAppId)
     : mTopFrameElement(nullptr)
     , mNestedFrameId(0)
     , mAppId(aAppId)

docshell/base/SerializedLoadContext.h

@@ -31,9 +31,9 @@ public:
     Init(nullptr);
   }
 
-  SerializedLoadContext(nsILoadContext* aLoadContext);
-  SerializedLoadContext(nsIChannel* aChannel);
-  SerializedLoadContext(nsIWebSocketChannel* aChannel);
+  explicit SerializedLoadContext(nsILoadContext* aLoadContext);
+  explicit SerializedLoadContext(nsIChannel* aChannel);
+  explicit SerializedLoadContext(nsIWebSocketChannel* aChannel);
 
   void Init(nsILoadContext* aLoadContext);
 

dom/animation/AnimationTimeline.h

@@ -21,7 +21,7 @@ namespace dom {
 class AnimationTimeline MOZ_FINAL : public nsWrapperCache
 {
 public:
-  AnimationTimeline(nsIDocument* aDocument)
+  explicit AnimationTimeline(nsIDocument* aDocument)
     : mDocument(aDocument)
   {
     SetIsDOMBinding();

dom/base/nsDOMClassInfo.h

@@ -77,7 +77,7 @@ protected:
   virtual ~nsDOMClassInfo();
 
 public:
-  nsDOMClassInfo(nsDOMClassInfoData* aData);
+  explicit nsDOMClassInfo(nsDOMClassInfoData* aData);
 
   NS_DECL_NSIXPCSCRIPTABLE
 
@@ -209,7 +209,7 @@ typedef nsDOMClassInfo nsDOMGenericSH;
 class nsEventTargetSH : public nsDOMGenericSH
 {
 protected:
-  nsEventTargetSH(nsDOMClassInfoData* aData) : nsDOMGenericSH(aData)
+  explicit nsEventTargetSH(nsDOMClassInfoData* aData) : nsDOMGenericSH(aData)
   {
   }
 
@@ -235,7 +235,7 @@ public:
 class nsWindowSH : public nsDOMGenericSH
 {
 protected:
-  nsWindowSH(nsDOMClassInfoData *aData) : nsDOMGenericSH(aData)
+  explicit nsWindowSH(nsDOMClassInfoData *aData) : nsDOMGenericSH(aData)
   {
   }
 
@@ -301,7 +301,7 @@ public:
 class nsDOMConstructorSH : public nsDOMGenericSH
 {
 protected:
-  nsDOMConstructorSH(nsDOMClassInfoData* aData) : nsDOMGenericSH(aData)
+  explicit nsDOMConstructorSH(nsDOMClassInfoData* aData) : nsDOMGenericSH(aData)
   {
   }
 
@@ -334,7 +334,7 @@ public:
 class nsNonDOMObjectSH : public nsDOMGenericSH
 {
 protected:
-  nsNonDOMObjectSH(nsDOMClassInfoData* aData) : nsDOMGenericSH(aData)
+  explicit nsNonDOMObjectSH(nsDOMClassInfoData* aData) : nsDOMGenericSH(aData)
   {
   }
 

dom/bindings/Date.h

@@ -19,7 +19,7 @@ class Date
 public:
   // Not inlining much here to avoid the includes we'd need.
   Date();
-  Date(double aMilliseconds)
+  explicit Date(double aMilliseconds)
     : mMsecSinceEpoch(aMilliseconds)
   {}
 

dom/bindings/MozMap.h

@@ -27,7 +27,7 @@ template<typename DataType>
 class MozMapEntry : public nsStringHashKey
 {
 public:
-  MozMapEntry(const nsAString* aKeyTypePointer)
+  explicit MozMapEntry(const nsAString* aKeyTypePointer)
     : nsStringHashKey(aKeyTypePointer)
   {
   }

dom/ipc/FileDescriptorSetChild.h

@@ -33,7 +33,7 @@ public:
   ForgetFileDescriptors(nsTArray<FileDescriptor>& aFileDescriptors);
 
 private:
-  FileDescriptorSetChild(const FileDescriptor& aFileDescriptor);
+  explicit FileDescriptorSetChild(const FileDescriptor& aFileDescriptor);
   ~FileDescriptorSetChild();
 
   virtual bool

dom/ipc/FileDescriptorSetParent.h

@@ -33,7 +33,7 @@ public:
   ForgetFileDescriptors(nsTArray<FileDescriptor>& aFileDescriptors);
 
 private:
-  FileDescriptorSetParent(const FileDescriptor& aFileDescriptor);
+  explicit FileDescriptorSetParent(const FileDescriptor& aFileDescriptor);
   ~FileDescriptorSetParent();
 
   virtual void ActorDestroy(ActorDestroyReason aWhy) MOZ_OVERRIDE;

dom/network/src/UDPSocketParent.h

@@ -22,7 +22,7 @@ public:
   NS_DECL_THREADSAFE_ISUPPORTS
   NS_DECL_NSIUDPSOCKETLISTENER
 
-  UDPSocketParent(nsIUDPSocketFilter* filter) :
+  explicit UDPSocketParent(nsIUDPSocketFilter* filter) :
     mIPCOpen(true),
     mFilter(filter) {}
 

dom/quota/QuotaManager.h

@@ -513,7 +513,7 @@ private:
 class AutoEnterWindow
 {
 public:
-  AutoEnterWindow(nsPIDOMWindow* aWindow)
+  explicit AutoEnterWindow(nsPIDOMWindow* aWindow)
   {
     QuotaManager::SetCurrentWindow(aWindow);
   }

dom/smil/nsSMILAnimationController.h

@@ -44,7 +44,7 @@ class nsSMILAnimationController : public nsSMILTimeContainer,
                                   public nsARefreshObserver
 {
 public:
-  nsSMILAnimationController(nsIDocument* aDoc);
+  explicit nsSMILAnimationController(nsIDocument* aDoc);
 
   // Clears mDocument pointer. (Called by our nsIDocument when it's going away)
   void Disconnect();

dom/smil/nsSMILInstanceTime.h

@@ -50,10 +50,10 @@ public:
     SOURCE_EVENT
   };
 
-  nsSMILInstanceTime(const nsSMILTimeValue& aTime,
-                     nsSMILInstanceTimeSource aSource = SOURCE_NONE,
-                     nsSMILTimeValueSpec* aCreator = nullptr,
-                     nsSMILInterval* aBaseInterval = nullptr);
+  explicit nsSMILInstanceTime(const nsSMILTimeValue& aTime,
+                              nsSMILInstanceTimeSource aSource = SOURCE_NONE,
+                              nsSMILTimeValueSpec* aCreator = nullptr,
+                              nsSMILInterval* aBaseInterval = nullptr);
 
   void Unlink();
   void HandleChangedInterval(const nsSMILTimeContainer* aSrcContainer,

dom/smil/nsSMILTimeValueSpec.h

@@ -89,7 +89,7 @@ protected:
   class TimeReferenceElement : public nsReferencedElement
   {
   public:
-    TimeReferenceElement(nsSMILTimeValueSpec* aOwner) : mSpec(aOwner) { }
+    explicit TimeReferenceElement(nsSMILTimeValueSpec* aOwner) : mSpec(aOwner) { }
     void ResetWithElement(Element* aTo) {
       nsRefPtr<Element> from = get();
       Unlink();
@@ -113,7 +113,7 @@ protected:
   {
     ~EventListener() {}
   public:
-    EventListener(nsSMILTimeValueSpec* aOwner) : mSpec(aOwner) { }
+    explicit EventListener(nsSMILTimeValueSpec* aOwner) : mSpec(aOwner) { }
     void Disconnect()
     {
       mSpec = nullptr;