Bug 1842460 - Remove dom.window.history.async pref r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D183708

dom/base/nsHistory.cpp

@@ -152,16 +152,9 @@ void nsHistory::Go(int32_t aDelta, nsIPrincipal& aSubjectPrincipal,
                               ? CallerType::System
                               : CallerType::NonSystem;
 
-  // Ignore the return value from Go(), since returning errors from Go() can
-  // lead to exceptions and a possible leak of history length
   // AsyncGo throws if we hit the location change rate limit.
-  if (StaticPrefs::dom_window_history_async()) {
-    session_history->AsyncGo(aDelta, /* aRequireUserInteraction = */ false,
-                             userActivation, callerType, aRv);
-  } else {
-    session_history->Go(aDelta, /* aRequireUserInteraction = */ false,
-                        userActivation, IgnoreErrors());
-  }
+  session_history->AsyncGo(aDelta, /* aRequireUserInteraction = */ false,
+                           userActivation, callerType, aRv);
 }
 
 void nsHistory::Back(CallerType aCallerType, ErrorResult& aRv) {
@@ -184,13 +177,8 @@ void nsHistory::Back(CallerType aCallerType, ErrorResult& aRv) {
           ? win->GetWindowContext()->HasValidTransientUserGestureActivation()
           : false;
 
-  if (StaticPrefs::dom_window_history_async()) {
-    sHistory->AsyncGo(-1, /* aRequireUserInteraction = */ false, userActivation,
-                      aCallerType, aRv);
-  } else {
-    sHistory->Go(-1, /* aRequireUserInteraction = */ false, userActivation,
-                 IgnoreErrors());
-  }
+  sHistory->AsyncGo(-1, /* aRequireUserInteraction = */ false, userActivation,
+                    aCallerType, aRv);
 }
 
 void nsHistory::Forward(CallerType aCallerType, ErrorResult& aRv) {
@@ -213,13 +201,8 @@ void nsHistory::Forward(CallerType aCallerType, ErrorResult& aRv) {
           ? win->GetWindowContext()->HasValidTransientUserGestureActivation()
           : false;
 
-  if (StaticPrefs::dom_window_history_async()) {
-    sHistory->AsyncGo(1, /* aRequireUserInteraction = */ false, userActivation,
-                      aCallerType, aRv);
-  } else {
-    sHistory->Go(1, /* aRequireUserInteraction = */ false, userActivation,
-                 IgnoreErrors());
-  }
+  sHistory->AsyncGo(1, /* aRequireUserInteraction = */ false, userActivation,
+                    aCallerType, aRv);
 }
 
 void nsHistory::PushState(JSContext* aCx, JS::Handle<JS::Value> aData,

modules/libpref/init/StaticPrefList.yaml

@@ -4733,12 +4733,7 @@
   type: bool
   value: true
   mirror: always
-
-- name: dom.window.history.async
-  type: bool
-  value: true
-  mirror: always
-
+  
 - name: dom.window.clientinformation.enabled
   type: bool
   value: true