Backed out changeset 05f1cba504d0 (bug 1573859) for perma fails on browser_misused_characters_in_strings.js. CLOSED TREE

devtools/client/debugger/panel.js

@@ -92,11 +92,6 @@ DebuggerPanel.prototype = {
     hud.ui.wrapper.dispatchEvaluateExpression(input);
   },
 
-  openInspector: async function() {
-    await this.toolbox.initInspector();
-    this.toolbox.selectTool("inspector");
-  },
-
   openElementInInspector: async function(gripOrFront) {
     const onSelectInspector = this.toolbox.selectTool("inspector");
     const onGripNodeToFront = getNodeFront(gripOrFront, this.toolbox);

devtools/client/debugger/src/actions/toolbox.js

@@ -29,12 +29,6 @@ export function openElementInInspectorCommand(grip: Grip) {
   };
 }
 
-export function openInspector(grip: Grip) {
-  return async ({ panel }: ThunkArgs) => {
-    return panel.openInspector();
-  };
-}
-
 export function highlightDomElement(grip: Grip) {
   return async ({ panel }: ThunkArgs) => {
     return panel.highlightDomElement(grip);

devtools/client/debugger/src/client/firefox/types.js

@@ -383,7 +383,6 @@ export type ThreadFront = {
 export type Panel = {|
   emit: (eventName: string) => void,
   openLink: (url: string) => void,
-  openInspector: () => void,
   openElementInInspector: (grip: Object) => void,
   openConsoleAndEvaluate: (input: string) => void,
   highlightDomElement: (grip: Object) => void,

devtools/client/debugger/src/components/SecondaryPanes/DOMMutationBreakpoints.css

@@ -3,17 +3,10 @@
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
  .dom-mutation-empty {
-  padding: 6px 20px;
+  padding: 6px 0;
   text-align: center;
   font-style: italic;
   color: var(--theme-body-color);
-  white-space: normal;
- }
-
- .dom-mutation-empty a {
-   text-decoration: underline;
-   color: var(--theme-toolbar-selected-color);
-   cursor: pointer;
  }
 
 .dom-mutation-list * {

devtools/client/debugger/src/components/SecondaryPanes/DOMMutationBreakpoints.js

@@ -29,7 +29,6 @@ type Props = {
   openElementInInspector: typeof actions.openElementInInspectorCommand,
   highlightDomElement: typeof actions.highlightDomElement,
   unHighlightDomElement: typeof actions.unHighlightDomElement,
-  openInspector: typeof actions.openInspector,
   deleteBreakpoint: typeof deleteDOMMutationBreakpoint,
   toggleBreakpoint: typeof toggleDOMMutationBreakpointState,
   setSkipPausing: typeof actions.setSkipPausing,
@@ -91,20 +90,10 @@ class DOMMutationBreakpointsContents extends Component<Props> {
     );
   }
 
-  /* eslint-disable react/no-danger */
   renderEmpty() {
-    const { openInspector } = this.props;
-    const text = L10N.getStr("noDomMutationBreakpoints").replace(
-      "{{link}}",
-      `<a>${L10N.getStr("inspectorTool")}</a>`
-    );
-
     return (
       <div className="dom-mutation-empty">
-        <div
-          onClick={() => openInspector()}
-          dangerouslySetInnerHTML={{ __html: text }}
-        />
+        {L10N.getStr("noDomMutationBreakpointsText")}
       </div>
     );
   }
@@ -146,7 +135,6 @@ class DomMutationBreakpoints extends Component<Props> {
         highlightDomElement={this.props.highlightDomElement}
         unHighlightDomElement={this.props.unHighlightDomElement}
         setSkipPausing={this.props.setSkipPausing}
-        openInspector={this.props.openInspector}
       />
     );
   }
@@ -161,6 +149,5 @@ export default connect(
     highlightDomElement: actions.highlightDomElement,
     unHighlightDomElement: actions.unHighlightDomElement,
     setSkipPausing: actions.setSkipPausing,
-    openInspector: actions.openInspector,
   }
 )(DomMutationBreakpoints);

devtools/client/debugger/src/main.development.js

@@ -22,7 +22,6 @@ bootstrap(React, ReactDOM).then(connection => {
       const win = window.open(url, "_blank");
       win.focus();
     },
-    openInspector: () => console.log("opening inspector"),
     openElementInInspector: grip =>
       alert(`Opening node in Inspector: ${grip.class}`),
     openConsoleAndEvaluate: input => alert(`console.log: ${input}`),

devtools/client/locales/en-US/debugger.properties

@@ -131,12 +131,9 @@ noSourcesText=This page has no sources.
 # header.
 eventListenersHeader1=Event Listener Breakpoints
 
-# LOCALIZATION NOTE (noDomMutationBreakpoints): The text to
-# display in the DOM Mutation Breakpoints pane when there are no events.
-noDomMutationBreakpoints=Right click an element in the {{link}} and select "Break on…" to add a breakpoint
-
-# LOCALIZATION NOTE (inspectorTool): The text to describe the the Inspector tool
-inspectorTool=Inspector
+# LOCALIZATION NOTE (noDomMutationBreakpointsText): The text to display in the
+# DOM Mutation Breakpoints pane when there are no events.
+noDomMutationBreakpointsText=No breakpoints to display.
 
 # LOCALIZATION NOTE (domMutationHeader): The text to display in the
 # DOM Mutation Breakpoints header