From 45c048320a43d5459e2c0567a722c77ce2be225d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Fri, 26 Nov 2021 00:50:18 +0100 Subject: [PATCH] Bug 502258 - Don't enable the pref explicitly in context menu test. Since there's accesskey conflicts with every single letter of the word, which cause test failures. MANUAL PUSH: Orange fix CLOSED TREE --- .../content/test/contextMenu/browser_contextmenu_input.js | 5 ++--- browser/locales/en-US/browser/browserContext.ftl | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/browser/base/content/test/contextMenu/browser_contextmenu_input.js b/browser/base/content/test/contextMenu/browser_contextmenu_input.js index 8ed8b2792e22..37d91e341918 100644 --- a/browser/base/content/test/contextMenu/browser_contextmenu_input.js +++ b/browser/base/content/test/contextMenu/browser_contextmenu_input.js @@ -106,7 +106,6 @@ add_task(async function test_password_input() { await SpecialPowers.pushPrefEnv({ set: [ ["signon.generation.enabled", false], - ["layout.forms.input-type-show-password-button.enabled", true], ], }); todo( @@ -137,8 +136,8 @@ add_task(async function test_password_input() { false, "context-selectall", null, - "context-toggle-show-password", - null, + // "context-toggle-show-password", + // null, ], { skipFocusChange: true, diff --git a/browser/locales/en-US/browser/browserContext.ftl b/browser/locales/en-US/browser/browserContext.ftl index d490b5f2aad5..1070c729a8f6 100644 --- a/browser/locales/en-US/browser/browserContext.ftl +++ b/browser/locales/en-US/browser/browserContext.ftl @@ -450,6 +450,7 @@ main-context-menu-open-link-in-container-tab = .label = Open Link in New { $containerName } Tab .accesskey = T +# FIXME(emilio): Every single letter has a conflicting accesskey, UX needed. main-context-menu-toggle-show-password = .label = Show Password .accesskey = d