зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1286444 - Store uint32_t's in VideoPlaybackQuality - r=kinetik
Because VideoPlaybackQuality attributes are exposed as 'unsigned long' (aka uint32_t) in the webidl interface, it would be dangerous to accept and store them as uint64_t in the class. MozReview-Commit-ID: EhX4lhTbA3c --HG-- extra : rebase_source : ed1e745c7d69babe6875677e3c8a16a9d6f3172c
This commit is contained in:
Родитель
7400f56915
Коммит
46dec3c3f7
|
@ -16,9 +16,9 @@ namespace dom {
|
|||
|
||||
VideoPlaybackQuality::VideoPlaybackQuality(HTMLMediaElement* aElement,
|
||||
DOMHighResTimeStamp aCreationTime,
|
||||
uint64_t aTotalFrames,
|
||||
uint64_t aDroppedFrames,
|
||||
uint64_t aCorruptedFrames)
|
||||
uint32_t aTotalFrames,
|
||||
uint32_t aDroppedFrames,
|
||||
uint32_t aCorruptedFrames)
|
||||
: mElement(aElement)
|
||||
, mCreationTime(aCreationTime)
|
||||
, mTotalFrames(aTotalFrames)
|
||||
|
|
|
@ -21,9 +21,11 @@ public:
|
|||
NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(VideoPlaybackQuality)
|
||||
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS(VideoPlaybackQuality)
|
||||
|
||||
VideoPlaybackQuality(HTMLMediaElement* aElement, DOMHighResTimeStamp aCreationTime,
|
||||
uint64_t aTotalFrames, uint64_t aDroppedFrames,
|
||||
uint64_t aCorruptedFrames);
|
||||
VideoPlaybackQuality(HTMLMediaElement* aElement,
|
||||
DOMHighResTimeStamp aCreationTime,
|
||||
uint32_t aTotalFrames,
|
||||
uint32_t aDroppedFrames,
|
||||
uint32_t aCorruptedFrames);
|
||||
|
||||
HTMLMediaElement* GetParentObject() const;
|
||||
|
||||
|
@ -34,17 +36,17 @@ public:
|
|||
return mCreationTime;
|
||||
}
|
||||
|
||||
uint64_t TotalVideoFrames()
|
||||
uint32_t TotalVideoFrames()
|
||||
{
|
||||
return mTotalFrames;
|
||||
}
|
||||
|
||||
uint64_t DroppedVideoFrames()
|
||||
uint32_t DroppedVideoFrames()
|
||||
{
|
||||
return mDroppedFrames;
|
||||
}
|
||||
|
||||
uint64_t CorruptedVideoFrames()
|
||||
uint32_t CorruptedVideoFrames()
|
||||
{
|
||||
return mCorruptedFrames;
|
||||
}
|
||||
|
@ -54,9 +56,9 @@ private:
|
|||
|
||||
RefPtr<HTMLMediaElement> mElement;
|
||||
DOMHighResTimeStamp mCreationTime;
|
||||
uint64_t mTotalFrames;
|
||||
uint64_t mDroppedFrames;
|
||||
uint64_t mCorruptedFrames;
|
||||
uint32_t mTotalFrames;
|
||||
uint32_t mDroppedFrames;
|
||||
uint32_t mCorruptedFrames;
|
||||
};
|
||||
|
||||
} // namespace dom
|
||||
|
|
Загрузка…
Ссылка в новой задаче