From 4838fed3dc14f8b845224283e6d6154312280d5d Mon Sep 17 00:00:00 2001 From: Jeff Muizelaar Date: Mon, 19 Dec 2011 09:02:47 -0500 Subject: [PATCH] Bug 580786. Require gWindowUtils. r=dbaron We should have DOMWindowUtils everywhere and this cleans up the code. --- layout/tools/reftest/reftest.js | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/layout/tools/reftest/reftest.js b/layout/tools/reftest/reftest.js index 9196e127a322..93d8e77302d0 100644 --- a/layout/tools/reftest/reftest.js +++ b/layout/tools/reftest/reftest.js @@ -345,13 +345,9 @@ function InitAndStartRefTests() gThisChunk = 0; } - try { - gWindowUtils = gContainingWindow.QueryInterface(CI.nsIInterfaceRequestor).getInterface(CI.nsIDOMWindowUtils); - if (gWindowUtils && !gWindowUtils.compareCanvases) - gWindowUtils = null; - } catch (e) { - gWindowUtils = null; - } + gWindowUtils = gContainingWindow.QueryInterface(CI.nsIInterfaceRequestor).getInterface(CI.nsIDOMWindowUtils); + if (!gWindowUtils || !gWindowUtils.compareCanvases) + throw "nsIDOMWindowUtils inteface missing"; gIOService = CC[IO_SERVICE_CONTRACTID].getService(CI.nsIIOService); gDebug = CC[DEBUG_CONTRACTID].getService(CI.nsIDebug2); @@ -521,9 +517,9 @@ function BuildConditionSandbox(aURL) { } sandbox.layersGPUAccelerated = - gWindowUtils && gWindowUtils.layerManagerType != "Basic"; + gWindowUtils.layerManagerType != "Basic"; sandbox.layersOpenGL = - gWindowUtils && gWindowUtils.layerManagerType == "OpenGL"; + gWindowUtils.layerManagerType == "OpenGL"; // Shortcuts for widget toolkits. sandbox.Android = xr.OS == "Android"; @@ -1403,15 +1399,8 @@ function RecordResult(testRunTime, errorMsg, scriptResults) // whether the two renderings match: var equal; - if (gWindowUtils) { - differences = gWindowUtils.compareCanvases(gCanvas1, gCanvas2, {}); - equal = (differences == 0); - } else { - differences = -1; - var k1 = gCanvas1.toDataURL(); - var k2 = gCanvas2.toDataURL(); - equal = (k1 == k2); - } + differences = gWindowUtils.compareCanvases(gCanvas1, gCanvas2, {}); + equal = (differences == 0); // whether the comparison result matches what is in the manifest var test_passed = (equal == (gURLs[0].type == TYPE_REFTEST_EQUAL));