From 485f6911ddacafa89512aafb8031f9f9333dd433 Mon Sep 17 00:00:00 2001
From: Scott <scott.downe@gmail.com>
Date: Thu, 29 Jul 2021 19:04:17 +0000
Subject: [PATCH] Bug 1722739 - Newtab Pocket privacy link hover underline fix
 r=amy

Differential Revision: https://phabricator.services.mozilla.com/D121124
---
 .../DiscoveryStreamComponents/Navigation/Navigation.jsx     | 6 ++----
 .../DiscoveryStreamComponents/Navigation/_Navigation.scss   | 4 ++++
 browser/components/newtab/css/activity-stream-linux.css     | 3 +++
 browser/components/newtab/css/activity-stream-mac.css       | 3 +++
 browser/components/newtab/css/activity-stream-windows.css   | 3 +++
 .../newtab/data/content/activity-stream.bundle.js           | 6 ++----
 6 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/Navigation.jsx b/browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/Navigation.jsx
index 5437d970527d..ef81ab8b4b3f 100644
--- a/browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/Navigation.jsx
+++ b/browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/Navigation.jsx
@@ -76,12 +76,10 @@ export class Navigation extends React.PureComponent {
 
         <SafeAnchor
           onLinkClick={this.onLinkClick}
-          className={this.props.className}
+          className="ds-navigation-privacy"
           url={privacyNotice.url}
         >
-          <FluentOrText message={privacyNotice.title}>
-            <span className="ds-navigation-privacy" />
-          </FluentOrText>
+          <FluentOrText message={privacyNotice.title} />
         </SafeAnchor>
       </div>
     );
diff --git a/browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/_Navigation.scss b/browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/_Navigation.scss
index 31430039cd50..55dcdd09a0e7 100644
--- a/browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/_Navigation.scss
+++ b/browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/_Navigation.scss
@@ -65,5 +65,9 @@
   .ds-navigation-privacy {
     padding-inline-start: 6px;
     float: inline-end;
+
+    &:hover {
+      text-decoration: underline;
+    }
   }
 }
diff --git a/browser/components/newtab/css/activity-stream-linux.css b/browser/components/newtab/css/activity-stream-linux.css
index 05e7f87ae7d7..1ee8863066e1 100644
--- a/browser/components/newtab/css/activity-stream-linux.css
+++ b/browser/components/newtab/css/activity-stream-linux.css
@@ -3790,6 +3790,9 @@ main.has-snippet {
   padding-inline-start: 6px;
   float: inline-end;
 }
+.ds-navigation .ds-navigation-privacy:hover {
+  text-decoration: underline;
+}
 
 .ds-section-title {
   text-align: center;
diff --git a/browser/components/newtab/css/activity-stream-mac.css b/browser/components/newtab/css/activity-stream-mac.css
index e830957e9fae..88ec66471eba 100644
--- a/browser/components/newtab/css/activity-stream-mac.css
+++ b/browser/components/newtab/css/activity-stream-mac.css
@@ -3794,6 +3794,9 @@ main.has-snippet {
   padding-inline-start: 6px;
   float: inline-end;
 }
+.ds-navigation .ds-navigation-privacy:hover {
+  text-decoration: underline;
+}
 
 .ds-section-title {
   text-align: center;
diff --git a/browser/components/newtab/css/activity-stream-windows.css b/browser/components/newtab/css/activity-stream-windows.css
index d2bf496c683e..f0b9e337662b 100644
--- a/browser/components/newtab/css/activity-stream-windows.css
+++ b/browser/components/newtab/css/activity-stream-windows.css
@@ -3790,6 +3790,9 @@ main.has-snippet {
   padding-inline-start: 6px;
   float: inline-end;
 }
+.ds-navigation .ds-navigation-privacy:hover {
+  text-decoration: underline;
+}
 
 .ds-section-title {
   text-align: center;
diff --git a/browser/components/newtab/data/content/activity-stream.bundle.js b/browser/components/newtab/data/content/activity-stream.bundle.js
index 68bbf93b6ef5..82636ec35e53 100644
--- a/browser/components/newtab/data/content/activity-stream.bundle.js
+++ b/browser/components/newtab/data/content/activity-stream.bundle.js
@@ -10015,13 +10015,11 @@ class Navigation extends react__WEBPACK_IMPORTED_MODULE_1___default.a.PureCompon
       dispatch: this.props.dispatch
     })))) : null, /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default.a.createElement(_SafeAnchor_SafeAnchor__WEBPACK_IMPORTED_MODULE_2__["SafeAnchor"], {
       onLinkClick: this.onLinkClick,
-      className: this.props.className,
+      className: "ds-navigation-privacy",
       url: privacyNotice.url
     }, /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default.a.createElement(content_src_components_FluentOrText_FluentOrText__WEBPACK_IMPORTED_MODULE_3__["FluentOrText"], {
       message: privacyNotice.title
-    }, /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_1___default.a.createElement("span", {
-      className: "ds-navigation-privacy"
-    }))));
+    })));
   }
 
 }