bullet-proof hiding the view. we might not have one if things are not dismissed correctly. r=pchen/sr=hyatt/a=asa. bug 83753.

layout/xul/base/src/nsPopupSetFrame.cpp

@@ -610,10 +610,15 @@ nsPopupSetFrame::ActivatePopup(PRBool aActivateFlag)
       content->GetDocument(*getter_AddRefs(doc));
       doc->FlushPendingNotifications();
          
-      // make sure we hide the popup.
+      // make sure we hide the popup. We can't assume that we'll have a view
+      // since we could be cleaning up after someone that didn't correctly 
+      // destroy the popup.
       nsIFrame* activeChild = GetActiveChild();
       nsIView* view = nsnull;
+      if ( activeChild ) {
         activeChild->GetView(mPresContext, &view);
+        NS_ASSERTION ( view, "View is gone, looks like someone forgot to rollup the popup!" );
+        if ( view ) {
           nsCOMPtr<nsIViewManager> viewManager;
           view->GetViewManager(*getter_AddRefs(viewManager));
           viewManager->SetViewVisibility(view, nsViewVisibility_kHide);
@@ -621,6 +626,8 @@ nsPopupSetFrame::ActivatePopup(PRBool aActivateFlag)
         }
       }
     }
+  }
+}
 
 PRBool
 nsPopupSetFrame::OnCreate(nsIContent* aPopupContent)