diff --git a/intl/unicharutil/util/nsUnicharUtils.cpp b/intl/unicharutil/util/nsUnicharUtils.cpp index a3baa7561056..c0e23f1a9f64 100644 --- a/intl/unicharutil/util/nsUnicharUtils.cpp +++ b/intl/unicharutil/util/nsUnicharUtils.cpp @@ -162,32 +162,6 @@ void ToFoldedCase(const char16_t* aIn, char16_t* aOut, uint32_t aLen) { } } -uint32_t ToNaked(uint32_t aChar) { - if (IS_ASCII(aChar)) { - return aChar; - } - return mozilla::unicode::GetNaked(aChar); -} - -void ToNaked(nsAString& aString) { - char16_t* buf = aString.BeginWriting(); - ToNaked(buf, buf, aString.Length()); -} - -void ToNaked(const char16_t* aIn, char16_t* aOut, uint32_t aLen) { - for (uint32_t i = 0; i < aLen; i++) { - uint32_t ch = aIn[i]; - if (i < aLen - 1 && NS_IS_SURROGATE_PAIR(ch, aIn[i + 1])) { - ch = mozilla::unicode::GetNaked(SURROGATE_TO_UCS4(ch, aIn[i + 1])); - NS_ASSERTION(!IS_IN_BMP(ch), "stripping crossed BMP/SMP boundary!"); - aOut[i++] = H_SURROGATE(ch); - aOut[i] = L_SURROGATE(ch); - continue; - } - aOut[i] = ToNaked(ch); - } -} - int32_t nsCaseInsensitiveStringComparator::operator()(const char16_t* lhs, const char16_t* rhs, uint32_t lLength, diff --git a/intl/unicharutil/util/nsUnicharUtils.h b/intl/unicharutil/util/nsUnicharUtils.h index ea02c5dd5aa9..1f1d1a949ae1 100644 --- a/intl/unicharutil/util/nsUnicharUtils.h +++ b/intl/unicharutil/util/nsUnicharUtils.h @@ -56,10 +56,6 @@ uint32_t ToFoldedCase(uint32_t aChar); void ToFoldedCase(nsAString& aString); void ToFoldedCase(const char16_t* aIn, char16_t* aOut, uint32_t aLen); -uint32_t ToNaked(uint32_t aChar); -void ToNaked(nsAString& aString); -void ToNaked(const char16_t* aIn, char16_t* aOut, uint32_t aLen); - class nsCaseInsensitiveStringComparator : public nsStringComparator { public: nsCaseInsensitiveStringComparator() = default; diff --git a/intl/unicharutil/util/nsUnicodeProperties.cpp b/intl/unicharutil/util/nsUnicodeProperties.cpp index fdb1500f5ed0..a03ffc5d5452 100644 --- a/intl/unicharutil/util/nsUnicodeProperties.cpp +++ b/intl/unicharutil/util/nsUnicodeProperties.cpp @@ -8,11 +8,8 @@ #include "nsUnicodePropertyData.cpp" #include "mozilla/ArrayUtils.h" -#include "mozilla/HashTable.h" #include "nsCharTraits.h" -#include "unicode/normalizer2.h" - #define UNICODE_BMP_LIMIT 0x10000 #define UNICODE_LIMIT 0x110000 @@ -308,50 +305,6 @@ uint32_t CountGraphemeClusters(const char16_t* aText, uint32_t aLength) { return result; } -uint32_t GetNaked(uint32_t aCh) { - using namespace mozilla; - - static const UNormalizer2* normalizer; - static HashMap decompositions; - - HashMap::Ptr entry = decompositions.lookup(aCh); - if (entry.found()) { - return entry->value(); - } - - UErrorCode error = U_ZERO_ERROR; - if (!normalizer) { - normalizer = unorm2_getNFDInstance(&error); - if (U_FAILURE(error)) { - return aCh; - } - } - - UChar ds[16]; - uint32_t dc; - if (unorm2_getDecomposition(normalizer, aCh, ds, sizeof(ds) / sizeof(UChar), - &error) > 0) { - if (NS_IS_HIGH_SURROGATE(ds[0])) { - dc = SURROGATE_TO_UCS4(ds[0], ds[1]); - } else { - dc = ds[0]; - } - if (IS_IN_BMP(dc) != IS_IN_BMP(aCh)) { - // Mappings that would change the length of a UTF-16 string are not - // currently supported. - dc = aCh; - } - if (!decompositions.putNew(aCh, dc)) { - // We're out of memory, so delete the cache to free some up. - decompositions.clearAndCompact(); - } - } else { - dc = aCh; - } - - return dc; -} - } // end namespace unicode } // end namespace mozilla diff --git a/intl/unicharutil/util/nsUnicodeProperties.h b/intl/unicharutil/util/nsUnicodeProperties.h index b34a527e360a..8922b1d0b436 100644 --- a/intl/unicharutil/util/nsUnicodeProperties.h +++ b/intl/unicharutil/util/nsUnicodeProperties.h @@ -229,9 +229,6 @@ class ClusterIterator { // Count the number of grapheme clusters in the given string uint32_t CountGraphemeClusters(const char16_t* aText, uint32_t aLength); -// Remove diacritics from a character -uint32_t GetNaked(uint32_t aCh); - // A simple reverse iterator for a string of char16_t codepoints that // advances by Unicode grapheme clusters class ClusterReverseIterator { diff --git a/mobile/android/app/mobile.js b/mobile/android/app/mobile.js index f75c660fa272..be20405902e5 100644 --- a/mobile/android/app/mobile.js +++ b/mobile/android/app/mobile.js @@ -238,7 +238,6 @@ pref("accessibility.typeaheadfind.flashBar", 1); pref("accessibility.typeaheadfind.linksonly", false); pref("accessibility.typeaheadfind.casesensitive", 0); pref("accessibility.browsewithcaret_shortcut.enabled", false); -pref("findbar.matchdiacritics", 0); // Whether the character encoding menu is under the main Firefox button. This // preference is a string so that localizers can alter it. diff --git a/mobile/android/modules/geckoview/GeckoViewContent.jsm b/mobile/android/modules/geckoview/GeckoViewContent.jsm index 684f165ea013..b52a161861e7 100644 --- a/mobile/android/modules/geckoview/GeckoViewContent.jsm +++ b/mobile/android/modules/geckoview/GeckoViewContent.jsm @@ -332,7 +332,6 @@ class GeckoViewContent extends GeckoViewModule { finder.caseSensitive = !!aData.matchCase; finder.entireWord = !!aData.wholeWord; - finder.matchDiacritics = !!aData.matchDiacritics; finder.addResultListener(this._finderListener); const drawOutline = diff --git a/modules/libpref/init/all.js b/modules/libpref/init/all.js index 95ec1ea437f9..6603051b82f8 100644 --- a/modules/libpref/init/all.js +++ b/modules/libpref/init/all.js @@ -768,11 +768,6 @@ pref("accessibility.typeaheadfind.matchesCountLimit", 1000); pref("findbar.highlightAll", false); pref("findbar.entireword", false); pref("findbar.iteratorTimeout", 100); -// matchdiacritics: controls the find bar's diacritic matching -// 0 - "never" (ignore diacritics) -// 1 - "always" (match diacritics) -// other - "auto" (match diacritics if input has diacritics, ignore otherwise) -pref("findbar.matchdiacritics", 0); // use Mac OS X Appearance panel text smoothing setting when rendering text, disabled by default pref("gfx.use_text_smoothing_setting", false); diff --git a/toolkit/actors/FinderChild.jsm b/toolkit/actors/FinderChild.jsm index 7fb6f39b0f7e..b2a084394098 100644 --- a/toolkit/actors/FinderChild.jsm +++ b/toolkit/actors/FinderChild.jsm @@ -28,10 +28,6 @@ class FinderChild extends JSWindowActorChild { this.finder.caseSensitive = data.caseSensitive; break; - case "Finder:MatchDiacritics": - this.finder.matchDiacritics = data.matchDiacritics; - break; - case "Finder:EntireWord": this.finder.entireWord = data.entireWord; break; diff --git a/toolkit/components/extensions/FindContent.jsm b/toolkit/components/extensions/FindContent.jsm index 930a3aea84c4..7ab732a138a4 100644 --- a/toolkit/components/extensions/FindContent.jsm +++ b/toolkit/components/extensions/FindContent.jsm @@ -51,7 +51,6 @@ class FindContent { * @param {string} queryphrase - the text to search for. * @param {boolean} caseSensitive - whether to use case sensitive matches. * @param {boolean} includeRangeData - whether to collect and return range data. - * @param {boolean} matchDiacritics - whether diacritics must match. * @param {boolean} searchString - whether to collect and return rect data. * * @returns {object} that includes: @@ -67,7 +66,6 @@ class FindContent { entireWord, includeRangeData, includeRectData, - matchDiacritics, } = params; this.iterator.reset(); @@ -79,7 +77,6 @@ class FindContent { entireWord: !!entireWord, finder: this.finder, listener: this.finder, - matchDiacritics: !!matchDiacritics, useSubFrames: false, }); diff --git a/toolkit/components/find/nsFind.cpp b/toolkit/components/find/nsFind.cpp index 4b6a73fd4e58..5e4e2aceee56 100644 --- a/toolkit/components/find/nsFind.cpp +++ b/toolkit/components/find/nsFind.cpp @@ -61,10 +61,7 @@ NS_IMPL_CYCLE_COLLECTING_RELEASE(nsFind) NS_IMPL_CYCLE_COLLECTION(nsFind) nsFind::nsFind() - : mFindBackward(false), - mCaseSensitive(false), - mMatchDiacritics(false), - mWordBreaker(nullptr) {} + : mFindBackward(false), mCaseSensitive(false), mWordBreaker(nullptr) {} nsFind::~nsFind() = default; @@ -400,22 +397,6 @@ nsFind::SetEntireWord(bool aEntireWord) { return NS_OK; } -NS_IMETHODIMP -nsFind::GetMatchDiacritics(bool* aMatchDiacritics) { - if (!aMatchDiacritics) { - return NS_ERROR_NULL_POINTER; - } - - *aMatchDiacritics = mMatchDiacritics; - return NS_OK; -} - -NS_IMETHODIMP -nsFind::SetMatchDiacritics(bool aMatchDiacritics) { - mMatchDiacritics = aMatchDiacritics; - return NS_OK; -} - // Here begins the find code. A ten-thousand-foot view of how it works: Find // needs to be able to compare across inline (but not block) nodes, e.g. find // for "abc" should match abc. So after we've searched a node, we're not @@ -526,9 +507,6 @@ nsFind::Find(const nsAString& aPatText, nsRange* aSearchRange, if (!mCaseSensitive) { ToFoldedCase(patAutoStr); } - if (!mMatchDiacritics) { - ToNaked(patAutoStr); - } // Ignore soft hyphens in the pattern static const char kShy[] = {char(CH_SHY), 0}; @@ -707,13 +685,8 @@ nsFind::Find(const nsAString& aPatText, nsRange* aSearchRange, } if (!inWhitespace && IsSpace(patc)) { inWhitespace = true; - } else if (!inWhitespace) { - if (!mCaseSensitive) { - c = ToFoldedCase(c); - } - if (!mMatchDiacritics) { - c = ToNaked(c); - } + } else if (!inWhitespace && !mCaseSensitive) { + c = ToFoldedCase(c); } if (c == CH_SHY) { diff --git a/toolkit/components/find/nsFind.h b/toolkit/components/find/nsFind.h index 37668f702709..76cc4537d717 100644 --- a/toolkit/components/find/nsFind.h +++ b/toolkit/components/find/nsFind.h @@ -42,7 +42,6 @@ class nsFind : public nsIFind { // Parameters set from the interface: bool mFindBackward; bool mCaseSensitive; - bool mMatchDiacritics; // Use "find entire words" mode by setting to a word breaker or null, to // disable "entire words" mode. diff --git a/toolkit/components/find/nsFindService.cpp b/toolkit/components/find/nsFindService.cpp index 7499132c2c2c..1d1731787f94 100644 --- a/toolkit/components/find/nsFindService.cpp +++ b/toolkit/components/find/nsFindService.cpp @@ -79,13 +79,3 @@ NS_IMETHODIMP nsFindService::SetMatchCase(bool aMatchCase) { mMatchCase = aMatchCase; return NS_OK; } - -NS_IMETHODIMP nsFindService::GetMatchDiacritics(bool* aMatchDiacritics) { - NS_ENSURE_ARG_POINTER(aMatchDiacritics); - *aMatchDiacritics = mMatchDiacritics; - return NS_OK; -} -NS_IMETHODIMP nsFindService::SetMatchDiacritics(bool aMatchDiacritics) { - mMatchDiacritics = aMatchDiacritics; - return NS_OK; -} diff --git a/toolkit/components/find/nsFindService.h b/toolkit/components/find/nsFindService.h index 5204076f5d91..595b797728a7 100644 --- a/toolkit/components/find/nsFindService.h +++ b/toolkit/components/find/nsFindService.h @@ -40,5 +40,4 @@ class nsFindService : public nsIFindService { bool mWrapFind; bool mEntireWord; bool mMatchCase; - bool mMatchDiacritics; }; diff --git a/toolkit/components/find/nsIFind.idl b/toolkit/components/find/nsIFind.idl index 941ed56cacc3..6cae5dff63c7 100644 --- a/toolkit/components/find/nsIFind.idl +++ b/toolkit/components/find/nsIFind.idl @@ -15,7 +15,6 @@ interface nsIFind : nsISupports attribute boolean findBackwards; attribute boolean caseSensitive; attribute boolean entireWord; - attribute boolean matchDiacritics; /** * Find some text in the current context. The implementation is diff --git a/toolkit/components/find/nsIFindService.idl b/toolkit/components/find/nsIFindService.idl index f5a5e18ce653..0c1b0e215e62 100644 --- a/toolkit/components/find/nsIFindService.idl +++ b/toolkit/components/find/nsIFindService.idl @@ -22,6 +22,5 @@ interface nsIFindService : nsISupports attribute boolean wrapFind; attribute boolean entireWord; attribute boolean matchCase; - attribute boolean matchDiacritics; }; diff --git a/toolkit/components/find/nsIWebBrowserFind.idl b/toolkit/components/find/nsIWebBrowserFind.idl index 1a78ea7269a0..634d39973acc 100644 --- a/toolkit/components/find/nsIWebBrowserFind.idl +++ b/toolkit/components/find/nsIWebBrowserFind.idl @@ -79,13 +79,6 @@ interface nsIWebBrowserFind : nsISupports */ attribute boolean matchCase; - /** - * matchDiacritics - * - * Whether to match diacritics when searching. Default is false. - */ - attribute boolean matchDiacritics; - /** * searchFrames * diff --git a/toolkit/components/find/nsWebBrowserFind.cpp b/toolkit/components/find/nsWebBrowserFind.cpp index d61612271969..d1c1f0800959 100644 --- a/toolkit/components/find/nsWebBrowserFind.cpp +++ b/toolkit/components/find/nsWebBrowserFind.cpp @@ -54,7 +54,6 @@ nsWebBrowserFind::nsWebBrowserFind() mWrapFind(false), mEntireWord(false), mMatchCase(false), - mMatchDiacritics(false), mSearchSubFrames(true), mSearchParentFrames(true) {} @@ -291,19 +290,6 @@ nsWebBrowserFind::SetMatchCase(bool aMatchCase) { return NS_OK; } -NS_IMETHODIMP -nsWebBrowserFind::GetMatchDiacritics(bool* aMatchDiacritics) { - NS_ENSURE_ARG_POINTER(aMatchDiacritics); - *aMatchDiacritics = mMatchDiacritics; - return NS_OK; -} - -NS_IMETHODIMP -nsWebBrowserFind::SetMatchDiacritics(bool aMatchDiacritics) { - mMatchDiacritics = aMatchDiacritics; - return NS_OK; -} - void nsWebBrowserFind::SetSelectionAndScroll(nsPIDOMWindowOuter* aWindow, nsRange* aRange) { RefPtr doc = aWindow->GetDoc(); @@ -640,7 +626,6 @@ nsresult nsWebBrowserFind::SearchInFrame(nsPIDOMWindowOuter* aWindow, NS_ENSURE_SUCCESS(rv, rv); (void)find->SetCaseSensitive(mMatchCase); - (void)find->SetMatchDiacritics(mMatchDiacritics); (void)find->SetFindBackwards(mFindBackwards); (void)find->SetEntireWord(mEntireWord); diff --git a/toolkit/components/find/nsWebBrowserFind.h b/toolkit/components/find/nsWebBrowserFind.h index e3d537a1a091..b5cb0f096d3b 100644 --- a/toolkit/components/find/nsWebBrowserFind.h +++ b/toolkit/components/find/nsWebBrowserFind.h @@ -81,7 +81,6 @@ class nsWebBrowserFind : public nsIWebBrowserFind, bool mWrapFind; bool mEntireWord; bool mMatchCase; - bool mMatchDiacritics; bool mSearchSubFrames; bool mSearchParentFrames; diff --git a/toolkit/components/typeaheadfind/nsITypeAheadFind.idl b/toolkit/components/typeaheadfind/nsITypeAheadFind.idl index 2f94136e72bf..9bfb39874921 100644 --- a/toolkit/components/typeaheadfind/nsITypeAheadFind.idl +++ b/toolkit/components/typeaheadfind/nsITypeAheadFind.idl @@ -70,7 +70,6 @@ interface nsITypeAheadFind : nsISupports readonly attribute AString searchString; // Most recent search string attribute boolean caseSensitive; // Searches are case sensitive - attribute boolean matchDiacritics; // Searches preserve diacritics attribute boolean entireWord; // Search for whole words only readonly attribute Element foundLink; // Most recent elem found, if a link diff --git a/toolkit/components/typeaheadfind/nsTypeAheadFind.cpp b/toolkit/components/typeaheadfind/nsTypeAheadFind.cpp index 434797b8765b..eb5cad390f80 100644 --- a/toolkit/components/typeaheadfind/nsTypeAheadFind.cpp +++ b/toolkit/components/typeaheadfind/nsTypeAheadFind.cpp @@ -86,8 +86,7 @@ nsTypeAheadFind::nsTypeAheadFind() mLastFindLength(0), mIsSoundInitialized(false), mCaseSensitive(false), - mEntireWord(false), - mMatchDiacritics(false) {} + mEntireWord(false) {} nsTypeAheadFind::~nsTypeAheadFind() { nsCOMPtr prefInternal( @@ -212,24 +211,6 @@ nsTypeAheadFind::GetEntireWord(bool* isEntireWord) { return NS_OK; } -NS_IMETHODIMP -nsTypeAheadFind::SetMatchDiacritics(bool matchDiacritics) { - mMatchDiacritics = matchDiacritics; - - if (mFind) { - mFind->SetMatchDiacritics(mMatchDiacritics); - } - - return NS_OK; -} - -NS_IMETHODIMP -nsTypeAheadFind::GetMatchDiacritics(bool* matchDiacritics) { - *matchDiacritics = mMatchDiacritics; - - return NS_OK; -} - NS_IMETHODIMP nsTypeAheadFind::SetDocShell(nsIDocShell* aDocShell) { mDocShell = do_GetWeakReference(aDocShell); diff --git a/toolkit/components/typeaheadfind/nsTypeAheadFind.h b/toolkit/components/typeaheadfind/nsTypeAheadFind.h index 388a6f8c2be3..1d265b28e0f3 100644 --- a/toolkit/components/typeaheadfind/nsTypeAheadFind.h +++ b/toolkit/components/typeaheadfind/nsTypeAheadFind.h @@ -120,7 +120,6 @@ class nsTypeAheadFind : public nsITypeAheadFind, bool mCaseSensitive; bool mEntireWord; - bool mMatchDiacritics; bool EnsureFind() { if (mFind) { @@ -134,7 +133,6 @@ class nsTypeAheadFind : public nsITypeAheadFind, mFind->SetCaseSensitive(mCaseSensitive); mFind->SetEntireWord(mEntireWord); - mFind->SetMatchDiacritics(mMatchDiacritics); return true; } diff --git a/toolkit/components/windowcreator/test/test_nsFind.html b/toolkit/components/windowcreator/test/test_nsFind.html index b8a02de77f7b..9689d21a219c 100644 --- a/toolkit/components/windowcreator/test/test_nsFind.html +++ b/toolkit/components/windowcreator/test/test_nsFind.html @@ -1,7 +1,6 @@