Bug 1348665 part 3 - Remove the aFlags param to SyncFrameViewProperties because all callers pass zero. r=tnikkel

MozReview-Commit-ID: 7zohl3bOsO1

layout/generic/nsFrame.cpp

@@ -1021,8 +1021,7 @@ void
 nsIFrame::SyncFrameViewProperties(nsPresContext*  aPresContext,
                                  nsIFrame*        aFrame,
                                  nsStyleContext*  aStyleContext,
-                                 nsView*          aView,
+                                 nsView*          aView)
-                                 uint32_t         aFlags)
 {
   NS_ASSERTION(!aStyleContext || aFrame->StyleContext() == aStyleContext,
                "Wrong style context for frame?");
@@ -1038,8 +1037,7 @@ nsIFrame::SyncFrameViewProperties(nsPresContext*  aPresContext,
   }
 
   // Make sure visibility is correct. This only affects nsSubdocumentFrame.
-  if (0 == (aFlags & NS_FRAME_NO_VISIBILITY) &&
+  if (!aFrame->SupportsVisibilityHidden()) {
-      !aFrame->SupportsVisibilityHidden()) {
     // See if the view should be hidden or visible
     vm->SetViewVisibility(aView,
         aStyleContext->StyleVisibility()->IsVisible()

layout/generic/nsIFrame.h

@@ -2487,8 +2487,7 @@ public:
   static void SyncFrameViewProperties(nsPresContext*  aPresContext,
                                       nsIFrame*        aFrame,
                                       nsStyleContext*  aStyleContext,
-                                      nsView*         aView,
+                                      nsView*         aView);
-                                      uint32_t         aFlags = 0);
 
   /**
    * Get the offset between the coordinate systems of |this| and aOther.

layout/xul/nsMenuPopupFrame.cpp

@@ -530,7 +530,7 @@ nsMenuPopupFrame::LayoutPopup(nsBoxLayoutState& aState, nsIFrame* aParentMenu,
     }
 
     viewManager->SetViewVisibility(view, nsViewVisibility_kShow);
-    nsContainerFrame::SyncFrameViewProperties(pc, this, nullptr, view, 0);
+    nsContainerFrame::SyncFrameViewProperties(pc, this, nullptr, view);
   }
 
   // finally, if the popup just opened, send a popupshown event