Bug 1549326 - Remove simpletest.js from eval()-whitelist, r=ckerschb

Amend several test files for triggering eval() assertion through simpletest.js

Differential Revision: https://phabricator.services.mozilla.com/D30474

--HG--
extra : moz-landing-system : lando

dom/base/test/chrome/cpows_parent.xul

@@ -510,7 +510,7 @@
 
     function finish() {
       ok(gReceivedErrorProbe, "Should have reported error probe");
-      opener.setTimeout("done()", 0);
+      opener.setTimeout(function() { this.done(); }, 0);
       window.close();
     }
   ]]></script>

dom/base/test/chrome/file_bug1139964.xul

@@ -44,7 +44,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1139964
     ok(m.data.hasTextEncoder, "BrowserChildGlobal should have TextEncoder object in the global scope!");
     ok(m.data.hasWindow, "BrowserChildGlobal should have Window object in the global scope!");
 
-    opener.setTimeout("done()", 0);
+    opener.setTimeout(function() { this.done(); }, 0);
     window.close();
   }
 

dom/base/test/chrome/file_bug1209621.xul

@@ -64,7 +64,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1209621
     is(treeOwner.primaryContentShell, null,
        "There shouldn't be primaryContentShell because no browser has primary=true.");
 
-    opener.setTimeout("done()", 0);
+    opener.setTimeout(function() { this.done(); }, 0);
     window.close();
   }
 

dom/base/test/chrome/file_bug549682.xul

@@ -119,7 +119,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=549682
   }
 
   function finish() {
-    opener.setTimeout("done()", 0);
+    opener.setTimeout(function() { this.done(); }, 0);
     var i = document.getElementById("ifr");
     i.remove(); // This is a crash test!
     window.close();

dom/base/test/chrome/file_bug616841.xul

@@ -53,7 +53,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=616841
     }
 
     function finish() {
-      opener.setTimeout("done()", 0);
+      opener.setTimeout(function() { this.done(); }, 0);
       window.close();
     }
 

dom/base/test/chrome/file_bug816340.xul

@@ -60,7 +60,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=816340
         testElement(elems[i], true, false);
       }
       ok(true, "done");
-      opener.setTimeout("done()", 0);
+      opener.setTimeout(function() { this.done(); }, 0);
       window.close();
     }
 

dom/base/test/chrome/file_bug990812-1.xul

@@ -40,7 +40,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=990812
         opener.wrappedJSObject.is(msg.data, next, "received test:" + next);
 
         if (order.length == 0) {
-          opener.setTimeout("next()");
+          opener.setTimeout(function() { this.next(); });
           window.close();
         }
       });

dom/base/test/chrome/file_bug990812-2.xul

@@ -44,7 +44,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=990812
       browser.messageManager.loadFrameScript(FRAME_SCRIPT, true);
 
       Promise.all([global, window, group]).then(function () {
-        opener.setTimeout("next()");
+        opener.setTimeout(function() { this.next(); });
         self.close();
       });
     }

dom/base/test/chrome/file_bug990812-3.xul

@@ -55,7 +55,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=990812
       globalMM.broadcastAsyncMessage("test", "global");
 
       Promise.all([promise1, promise2]).then(function () {
-        opener.setTimeout("next()");
+        opener.setTimeout(function() { this.next(); });
         window.close();
       });
     }

dom/base/test/chrome/file_bug990812-4.xul

@@ -50,7 +50,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=990812
       messageManager.broadcastAsyncMessage("test");
 
       Promise.all([promise1, promise2]).then(function () {
-        opener.setTimeout("next()");
+        opener.setTimeout(function() { this.next(); });
         window.close();
       });
     }

dom/base/test/chrome/file_bug990812-5.xul

@@ -58,7 +58,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=990812
       messageManager.broadcastAsyncMessage("test");
 
       Promise.all([promise1, promise2]).then(function () {
-        opener.setTimeout("next()");
+        opener.setTimeout(function() { this.next(); });
         window.close();
       });
     }

dom/messagechannel/tests/mm_messageChannelParent.js

@@ -18,7 +18,7 @@ function todo_is(v1, v2, message) {
 }
 
 function finish() {
-  opener.setTimeout("done()", 0);
+  opener.setTimeout(function() { this.done(); }, 0);
   window.close();
 }
 

js/xpconnect/tests/chrome/file_bug618176.xul

@@ -38,7 +38,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=618176
     }
 
     function finish() {
-      opener.setTimeout("done()", 0);
+      opener.setTimeout(function() { this.done(); }, 0);
       window.close();
     }
 

layout/base/tests/chrome/test_bug1018265.xul

@@ -24,7 +24,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1018265
 
   function done() {
     ok(true, "done");
-    setTimeout("SimpleTest.finish()", 0);
+    setTimeout(function() { SimpleTest.finish(); }, 0);
   }
   ]]>
   </script>

modules/libpref/init/all.js

@@ -2661,7 +2661,7 @@ pref("csp.overrule_about_uris_without_csp_whitelist", false);
 pref("csp.skip_about_page_has_csp_assert", false);
 // assertion flag will be set to false after fixing Bug 1473549
 pref("security.allow_eval_with_system_principal", false);
-pref("security.uris_using_eval_with_system_principal", "autocomplete.xml,redux.js,react-redux.js,content-task.js,preferencesbindings.js,lodash.js,jszip.js,sinon-7.2.7.js,ajv-4.1.1.js,jsol.js,simpletest/simpletest.js");
+pref("security.uris_using_eval_with_system_principal", "autocomplete.xml,redux.js,react-redux.js,content-task.js,preferencesbindings.js,lodash.js,jszip.js,sinon-7.2.7.js,ajv-4.1.1.js,jsol.js");
 #endif
 
 #if defined(DEBUG) || defined(FUZZING)