From 4b87e8575c26fc1638fd0085455c70e3cf3c5386 Mon Sep 17 00:00:00 2001 From: Alex Chronopoulos Date: Tue, 1 May 2018 17:46:09 +0200 Subject: [PATCH] Bug 1456266 - In ConstantSourceNode change the default channelCount to align with the spec. r=padenot MozReview-Commit-ID: 9cvAztPuZic --HG-- extra : rebase_source : 5c1ce2f40ca199ac5dda174155c74e5212225aa4 --- dom/media/webaudio/ConstantSourceNode.cpp | 2 +- .../constant-source-basic.html.ini | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/dom/media/webaudio/ConstantSourceNode.cpp b/dom/media/webaudio/ConstantSourceNode.cpp index f03245fc6385..00ded3cd2d9b 100644 --- a/dom/media/webaudio/ConstantSourceNode.cpp +++ b/dom/media/webaudio/ConstantSourceNode.cpp @@ -146,7 +146,7 @@ public: ConstantSourceNode::ConstantSourceNode(AudioContext* aContext) : AudioScheduledSourceNode(aContext, - 1, + 2, ChannelCountMode::Max, ChannelInterpretation::Speakers) , mOffset(new AudioParam(this, ConstantSourceNodeEngine::OFFSET, diff --git a/testing/web-platform/meta/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic.html.ini b/testing/web-platform/meta/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic.html.ini index 3e0fc91eafbb..942caf1c1e5e 100644 --- a/testing/web-platform/meta/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic.html.ini +++ b/testing/web-platform/meta/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic.html.ini @@ -1,17 +1,11 @@ [constant-source-basic.html] - [X Factory method: node.channelCount is not equal to 2. Got 1.] - expected: FAIL - [X Factory method: node.offset.minValue is not equal to -3.4028234663852886e+38. Got -Infinity.] expected: FAIL [X Factory method: node.offset.maxValue is not equal to 3.4028234663852886e+38. Got Infinity.] expected: FAIL - [< [createConstantSource()\] 3 out of 11 assertions were failed.] - expected: FAIL - - [X Constructor: node.channelCount is not equal to 2. Got 1.] + [< [createConstantSource()\] 2 out of 11 assertions were failed.] expected: FAIL [X Constructor: node.offset.minValue is not equal to -3.4028234663852886e+38. Got -Infinity.] @@ -20,7 +14,7 @@ [X Constructor: node.offset.maxValue is not equal to 3.4028234663852886e+38. Got Infinity.] expected: FAIL - [< [new ConstantSourceNode()\] 3 out of 11 assertions were failed.] + [< [new ConstantSourceNode()\] 2 out of 11 assertions were failed.] expected: FAIL [X start(-1) threw "NotSupportedError" instead of RangeError.]