Bug 1641546 - Make the new WebRTC global sharing indicator a dialog instead of a popup. r=pbz

Depends on D77696

Differential Revision: https://phabricator.services.mozilla.com/D77504

browser/modules/webrtcUI.jsm

@@ -717,7 +717,7 @@ function getGlobalIndicator() {
   if (!webrtcUI.useLegacyGlobalIndicator) {
     const INDICATOR_CHROME_URI =
       "chrome://browser/content/webrtcIndicator.xhtml";
-    let features = "chrome,titlebar=no,alwaysontop,minimizable=yes,popup=yes";
+    let features = "chrome,titlebar=no,alwaysontop,minimizable=yes";
 
     /* Don't use dialog on Gtk as it adds extra border and titlebar to indicator */
     if (!AppConstants.MOZ_WIDGET_GTK) {

widget/tests/test_alwaysontop_focus.xhtml

@@ -8,11 +8,17 @@
   <script><![CDATA[
     add_task(async function testAlwaysOnTop() {
       const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm");
-      let topWin = docShell.rootTreeItem.domWindow;
+      let topWin = window.docShell.rootTreeItem.domWindow;
       await SimpleTest.promiseFocus(topWin);
       is(Services.focus.activeWindow, topWin, "Top level window is focused");
 
-      let newWin = Services.ww.openWindow(null, "about:blank", null, "chrome,alwaysontop,width=300,height=300", null);
+      let newWin = Services.ww.openWindow(
+        null,
+        "about:blank",
+        null,
+        "chrome,alwaysontop,width=300,height=300",
+        null
+      );
       await new Promise(resolve => {
         newWin.addEventListener("load", resolve, { once: true });
       });