Bug 1708228 - Part 2: Remove redundant flush param from nsIRadioGroupContainer r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D113806

dom/base/Document.h

@@ -589,9 +589,9 @@ class Document : public nsINode,
   } while (0)
 
   // nsIRadioGroupContainer
-  NS_IMETHOD WalkRadioGroup(const nsAString& aName, nsIRadioVisitor* aVisitor,
-                            bool aFlushContent) final {
-    return DocumentOrShadowRoot::WalkRadioGroup(aName, aVisitor, aFlushContent);
+  NS_IMETHOD WalkRadioGroup(const nsAString& aName,
+                            nsIRadioVisitor* aVisitor) final {
+    return DocumentOrShadowRoot::WalkRadioGroup(aName, aVisitor);
   }
 
   void SetCurrentRadioButton(const nsAString& aName,
@@ -2091,7 +2091,7 @@ class Document : public nsINode,
    * Another variant of the above FlushPendingNotifications.  This function
    * takes a ChangesToFlush to specify whether throttled animations are flushed
    * or not.
-   * If in doublt, use the above FlushPendingNotifications.
+   * If in doubt, use the above FlushPendingNotifications.
    */
   MOZ_CAN_RUN_SCRIPT_BOUNDARY
   void FlushPendingNotifications(ChangesToFlush aFlush);

dom/base/RadioGroupManager.cpp

@@ -50,8 +50,7 @@ void RadioGroupManager::Unlink(RadioGroupManager* tmp) {
 }
 
 nsresult RadioGroupManager::WalkRadioGroup(const nsAString& aName,
-                                           nsIRadioVisitor* aVisitor,
-                                           bool aFlushContent) {
+                                           nsIRadioVisitor* aVisitor) {
   nsRadioGroupStruct* radioGroup = GetOrCreateRadioGroup(aName);
 
   for (int i = 0; i < radioGroup->mRadioButtons.Count(); i++) {

dom/base/RadioGroupManager.h

@@ -31,8 +31,7 @@ class RadioGroupManager {
   static void Unlink(RadioGroupManager* tmp);
 
   // nsIRadioGroupContainer
-  NS_IMETHOD WalkRadioGroup(const nsAString& aName, nsIRadioVisitor* aVisitor,
-                            bool aFlushContent);
+  NS_IMETHOD WalkRadioGroup(const nsAString& aName, nsIRadioVisitor* aVisitor);
   void SetCurrentRadioButton(const nsAString& aName, HTMLInputElement* aRadio);
   HTMLInputElement* GetCurrentRadioButton(const nsAString& aName);
   nsresult GetNextRadioButton(const nsAString& aName, const bool aPrevious,

dom/base/ShadowRoot.h

@@ -209,9 +209,9 @@ class ShadowRoot final : public DocumentFragment,
   void GetEventTargetParent(EventChainPreVisitor& aVisitor) override;
 
   // nsIRadioGroupContainer
-  NS_IMETHOD WalkRadioGroup(const nsAString& aName, nsIRadioVisitor* aVisitor,
-                            bool aFlushContent) override {
-    return DocumentOrShadowRoot::WalkRadioGroup(aName, aVisitor, aFlushContent);
+  NS_IMETHOD WalkRadioGroup(const nsAString& aName,
+                            nsIRadioVisitor* aVisitor) override {
+    return DocumentOrShadowRoot::WalkRadioGroup(aName, aVisitor);
   }
   virtual void SetCurrentRadioButton(const nsAString& aName,
                                      HTMLInputElement* aRadio) override {

dom/html/HTMLFormElement.cpp

@@ -2044,8 +2044,8 @@ HTMLFormElement::GetNextRadioButton(const nsAString& aName,
 
 NS_IMETHODIMP
 HTMLFormElement::WalkRadioGroup(const nsAString& aName,
-                                nsIRadioVisitor* aVisitor, bool aFlushContent) {
-  return RadioGroupManager::WalkRadioGroup(aName, aVisitor, aFlushContent);
+                                nsIRadioVisitor* aVisitor) {
+  return RadioGroupManager::WalkRadioGroup(aName, aVisitor);
 }
 
 void HTMLFormElement::AddToRadioGroup(const nsAString& aName,

dom/html/HTMLFormElement.h

@@ -66,8 +66,8 @@ class HTMLFormElement final : public nsGenericHTMLElement,
   NS_IMETHOD GetNextRadioButton(const nsAString& aName, const bool aPrevious,
                                 HTMLInputElement* aFocusedRadio,
                                 HTMLInputElement** aRadioOut) override;
-  NS_IMETHOD WalkRadioGroup(const nsAString& aName, nsIRadioVisitor* aVisitor,
-                            bool aFlushContent) override;
+  NS_IMETHOD WalkRadioGroup(const nsAString& aName,
+                            nsIRadioVisitor* aVisitor) override;
   void AddToRadioGroup(const nsAString& aName,
                        HTMLInputElement* aRadio) override;
   void RemoveFromRadioGroup(const nsAString& aName,

dom/html/HTMLInputElement.cpp

@@ -6210,7 +6210,7 @@ nsresult HTMLInputElement::VisitGroup(nsIRadioVisitor* aVisitor,
   if (container) {
     nsAutoString name;
     GetAttr(kNameSpaceID_None, nsGkAtoms::name, name);
-    return container->WalkRadioGroup(name, aVisitor, aFlushContent);
+    return container->WalkRadioGroup(name, aVisitor);
   }
 
   aVisitor->Visit(this);

dom/html/nsIRadioGroupContainer.h

@@ -35,11 +35,9 @@ class nsIRadioGroupContainer : public nsISupports {
    * Walk through the radio group, visiting each note with avisitor->Visit()
    * @param aName the group name
    * @param aVisitor the visitor to visit with
-   * @param aFlushContent whether to ensure the content model is up to date
-   *        before walking.
    */
-  NS_IMETHOD WalkRadioGroup(const nsAString& aName, nsIRadioVisitor* aVisitor,
-                            bool aFlushContent) = 0;
+  NS_IMETHOD WalkRadioGroup(const nsAString& aName,
+                            nsIRadioVisitor* aVisitor) = 0;
 
   /**
    * Set the current radio button in a group