Bug 1632750 - Tweak about:profiling default buffer sizes - r=gregtatum

Presets used 16Mi entries (128MiB) by default, but these numbers were a limit per process.
Now that the limit is for the whole Firefox app, we would record a lot less information, because there are typically around 8 or more processes.
So the default are now 8 times larger to roughly record a similar amount of profiling data.

Also the custom buffer maximum size has been increased from 1GiB to 2GiB.

Differential Revision: https://phabricator.services.mozilla.com/D73216
This commit is contained in:
Gerald Squelart 2020-05-08 03:36:33 +00:00
Родитель 3b34acf6e6
Коммит 4e88697b5d
3 изменённых файлов: 7 добавлений и 7 удалений

Просмотреть файл

@ -195,7 +195,7 @@ class Settings extends PureComponent {
this._intervalExponentialScale = makeExponentialScale(0.01, 100); this._intervalExponentialScale = makeExponentialScale(0.01, 100);
this._entriesExponentialScale = makePowerOf2Scale( this._entriesExponentialScale = makePowerOf2Scale(
128 * 1024, 128 * 1024,
128 * 1024 * 1024 256 * 1024 * 1024
); );
} }

Просмотреть файл

@ -85,7 +85,7 @@ const presets = {
label: "Web Developer", label: "Web Developer",
description: description:
"Recommended preset for most web app debugging, with low overhead.", "Recommended preset for most web app debugging, with low overhead.",
entries: 16 * 1024 * 1024, entries: 128 * 1024 * 1024,
interval: 1, interval: 1,
features: ["screenshots", "js"], features: ["screenshots", "js"],
threads: ["GeckoMain", "Compositor", "Renderer", "DOM Worker"], threads: ["GeckoMain", "Compositor", "Renderer", "DOM Worker"],
@ -94,7 +94,7 @@ const presets = {
"firefox-platform": { "firefox-platform": {
label: "Firefox Platform", label: "Firefox Platform",
description: "Recommended preset for internal Firefox platform debugging.", description: "Recommended preset for internal Firefox platform debugging.",
entries: 16 * 1024 * 1024, entries: 128 * 1024 * 1024,
interval: 1, interval: 1,
features: ["screenshots", "js", "leaf", "stackwalk", "java"], features: ["screenshots", "js", "leaf", "stackwalk", "java"],
threads: ["GeckoMain", "Compositor", "Renderer"], threads: ["GeckoMain", "Compositor", "Renderer"],
@ -103,7 +103,7 @@ const presets = {
"firefox-front-end": { "firefox-front-end": {
label: "Firefox Front-End", label: "Firefox Front-End",
description: "Recommended preset for internal Firefox front-end debugging.", description: "Recommended preset for internal Firefox front-end debugging.",
entries: 16 * 1024 * 1024, entries: 128 * 1024 * 1024,
interval: 1, interval: 1,
features: ["screenshots", "js", "leaf", "stackwalk", "java"], features: ["screenshots", "js", "leaf", "stackwalk", "java"],
threads: ["GeckoMain", "Compositor", "Renderer", "DOM Worker"], threads: ["GeckoMain", "Compositor", "Renderer", "DOM Worker"],
@ -112,7 +112,7 @@ const presets = {
media: { media: {
label: "Media", label: "Media",
description: "Recommended preset for diagnosing audio and video problems.", description: "Recommended preset for diagnosing audio and video problems.",
entries: 16 * 1024 * 1024, entries: 128 * 1024 * 1024,
interval: 1, interval: 1,
features: ["js", "leaf", "stackwalk"], features: ["js", "leaf", "stackwalk"],
threads: [ threads: [

Просмотреть файл

@ -10,7 +10,7 @@ add_task(async function test() {
await withAboutProfiling(async document => { await withAboutProfiling(async document => {
is( is(
getActiveConfiguration().capacity, getActiveConfiguration().capacity,
Math.pow(2, 24), 128 * 1024 * 1024,
"The active configuration is set to a specific number initially. If this" + "The active configuration is set to a specific number initially. If this" +
" test fails here, then the magic numbers here may need to be adjusted." " test fails here, then the magic numbers here may need to be adjusted."
); );
@ -21,7 +21,7 @@ add_task(async function test() {
is( is(
getActiveConfiguration().capacity, getActiveConfiguration().capacity,
Math.pow(2, 18), 256 * 1024,
"The capacity changed to a smaller value." "The capacity changed to a smaller value."
); );
}); });