Backed out changeset 93572a1c05c8 (bug 1565776) for failures in LoginManagerParent CLOSED TREE

toolkit/components/passwordmgr/LoginManagerParent.jsm

@@ -725,13 +725,6 @@ this.LoginManagerParent = {
     if (logins.length > 0) {
       log("_onGeneratedPasswordFilled: Login already saved for this site");
       shouldSaveLogin = false;
-      for (let login of logins) {
-        if (formLogin.matches(login, false)) {
-          // This login is already saved so show no new UI.
-          log("_onGeneratedPasswordFilled: Matching login already saved");
-          return;
-        }
-      }
     }
 
     if (shouldSaveLogin) {
@@ -742,18 +735,6 @@ this.LoginManagerParent = {
     );
     let browser = browsingContext.top.embedderElement;
     let prompter = this._getPrompter(browser, openerTopWindowID);
-
-    if (shouldSaveLogin) {
-      // If we auto-saved the login then show a change doorhanger to allow
-      // modifying it e.g. adding a username.
-      prompter.promptToChangePassword(
-        formLogin,
-        formLogin,
-        true, // dimissed prompt
-        shouldSaveLogin // notifySaved
-      );
-      return;
-    }
     prompter.promptToSavePassword(
       formLogin,
       true, // dimissed prompt

toolkit/components/passwordmgr/test/browser/browser_generated_password_doorhangers.js

@@ -173,7 +173,7 @@ add_task(async function autocomplete_generated_password_auto_saved() {
       await hintPromiseHidden;
 
       // check a dismissed prompt was shown with extraAttr attribute
-      let notif = getCaptureDoorhanger("password-change");
+      let notif = getCaptureDoorhanger("password-save");
       ok(notif && notif.dismissed, "Dismissed notification was created");
       is(
         notif.anchorElement.getAttribute("extraAttr"),